[Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs.

chrome/browser/ui/views/browser_dialogs_views_mac.cc

Index: chrome/browser/ui/views/browser_dialogs_views_mac.cc
diff --git a/chrome/browser/ui/views/browser_dialogs_views_mac.cc b/chrome/browser/ui/views/browser_dialogs_views_mac.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8ebe96521ec54583cf3b46f4ada45213f63a799c
--- /dev/null
+++ b/chrome/browser/ui/views/browser_dialogs_views_mac.cc
@@ -0,0 +1,25 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/browser_dialogs.h"
+
+#include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
+#include "content/public/browser/web_contents_observer.h"

[msw, 2015/08/17 17:31:44]

This doesn't seem to be needed, forward declare content::WebContents if that's
even needed (already done in the header)

[jackhou1, 2015/08/18 01:20:53]

Done.

+#include "ui/views/widget/widget_observer.h"

[msw, 2015/08/17 17:31:45]

This doesn't seem to be needed.

[jackhou1, 2015/08/18 01:20:53]

Done.

+
+// This file provides definitions of desktop browser dialog-creation methods for

[msw, 2015/08/17 17:31:44]

q: Why doesn't this match Trent's pattern from
https://codereview.chromium.org/1274083002

[jackhou1, 2015/08/18 01:20:53]

Updated this comment to mention how it fits into builds.

The difference is:

c/b/ui/browser_dialogs_mac.cc: Only on Cocoa builds.
c/b/ui/views/browser_dialogs_views.cc: Only on non-Mac and mac_views_browser=1.
c/b/ui/views/browser_dialogs_views_mac.cc: On Cocoa builds, and needs to access
Views implementations.

[tapted, 2015/08/18 01:29:51]

Another aspect behind the difference is that ShowWebsiteSettings is called via a
vtable on BrowserWindow. So, for WebsiteSettings, *all* platforms have the same
definition of the global function to show the dialog, in browser_commands.cc (
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
)

We looked into doing the same pattern (i.e. replacing the ShowWebsiteSettings
global function with per-platform definitions). On Mac, both this global
function, and the BrowserWindow member function just end up forwarding
arguments, so it looked promising. However, for Views, some extra arguments from
BrowserWindow private members are added by the member function, so it wasn't a
neat fit.

(more about this in https://codereview.chromium.org/1280673003/#msg6 )

[msw, 2015/08/18 02:40:32]

Acknowledged.

+// Mac where a Cocoa browser is using Views dialogs.
+
+namespace chrome {
+
+void ShowWebsiteSettingsBubbleViewsAtPoint(const gfx::Point& anchor_point,
+                                           Profile* profile,
+                                           content::WebContents* web_contents,
+                                           const GURL& url,
+                                           const content::SSLStatus& ssl) {
+  WebsiteSettingsPopupView::ShowPopupAtRect(
+      gfx::Rect(anchor_point, gfx::Size()), profile, web_contents, url, ssl);
+}
+
+}  // namespace chrome