[Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs.

chrome/browser/ui/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/browser_window_cocoa.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #import "base/mac/sdk_forward_declarations.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/fullscreen.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/signin/chrome_signin_helper.h"
 #include "chrome/browser/translate/chrome_translate_client.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_command_controller.h"
 #include "chrome/browser/ui/browser_commands_mac.h"
+#include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window_state.h"
 #import "chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_utils.h"
 #import "chrome/browser/ui/cocoa/chrome_event_processing_window.h"
 #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_controller.h"
 #import "chrome/browser/ui/cocoa/download/download_shelf_controller.h"
 #include "chrome/browser/ui/cocoa/find_bar/find_bar_bridge.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
@@ skipping 655 matching lines @@
 
 void BrowserWindowCocoa::UserChangedTheme() {
   [controller_ userChangedTheme];
 }
 
 void BrowserWindowCocoa::ShowWebsiteSettings(
     Profile* profile,
     content::WebContents* web_contents,
     const GURL& url,
     const content::SSLStatus& ssl) {
+  if (chrome::ToolkitViewsDialogsEnabled()) {
+    LocationBarViewMac* location_bar = [controller_ locationBarBridge];

[tapted, 2015/08/10 05:44:23]

I think this needs to move to website_settings_bubble_controller.mm. In
WebsiteSettingsUIBridge::Show() Then, the logic is just

gfx::Point anchor = gfx::ScreenRectFromNSRect(
    gfx::Rect(AnchorForWindow(parent), gfx::Size()).origin();

Or.. possibly gfx::ScreenPointFromNSPoint(..). Maybe we've dodged around needing
that long enough and we should just add it.

`AnchorForWindow()` is [WebsiteSettingsBubbleController
anchorPointForWindowWithHeight:]. It has a `bubbleHeight` argument, but it's
unused and should be removed. It also doesn't need to be an instance method.
And, it's missing a prototype. So, lots of things to cleanup -- it should just
be an anonymous function.

[jackhou1, 2015/08/10 09:11:09]

Done.

+    NSPoint bubble_point = location_bar->GetPageInfoBubblePoint();
+    NSPoint bubble_point_screen = [window() convertBaseToScreen:bubble_point];
+    gfx::Point bubble_point_views(
+        bubble_point_screen.x,
+        NSMaxY([[window() screen] frame]) - bubble_point_screen.y);

[tapted, 2015/08/10 05:44:24]

I don't think this is right -- flipping always needs to happen in screen[0].

[jackhou1, 2015/08/10 09:11:09]

Done.

+
+    chrome::ShowWebsiteSettingsBubbleViewsAtPoint(
+        bubble_point_views, profile, web_contents, url, ssl, browser_);

[tapted, 2015/08/10 05:44:23]

I think the browser_ argument can be refactored out... it seems only used for
browser_->OpenURL(..) and the webcontents could do this just as capably, like it
does on Mac...

[jackhou1, 2015/08/10 09:11:09]

Done in https://codereview.chromium.org/1268243003/.

+    return;
+  }
+
   WebsiteSettingsUIBridge::Show(window(), profile, web_contents, url, ssl);
 }
 
 void BrowserWindowCocoa::ShowAppMenu() {
   // No-op. Mac doesn't support showing the menus via alt keys.
 }
 
 bool BrowserWindowCocoa::PreHandleKeyboardEvent(
     const NativeWebKeyboardEvent& event, bool* is_keyboard_shortcut) {
   // Handle ESC to dismiss permission bubbles, but still forward it
@@ skipping 133 matching lines @@
 void BrowserWindowCocoa::UnhideDownloadShelf() {
   GetDownloadShelf()->Unhide();
 }
 
 void BrowserWindowCocoa::HideDownloadShelf() {
   GetDownloadShelf()->Hide();
   StatusBubble* statusBubble = GetStatusBubble();
   if (statusBubble)
     statusBubble->Hide();
 }