[Mac] Enable MacViews site settings bubble behind --enable-mac-views-dialogs.

chrome/browser/ui/browser_dialogs_mac.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_dialogs.h"
 
 #include "base/command_line.h"
 #include "chrome/common/chrome_switches.cc"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/views/view.h"

[tapted, 2015/08/10 05:44:23]

this include shouldn't be allowed here, but I think DEPS misses it on a
technicality (suggested fix follows)

[jackhou1, 2015/08/10 09:11:09]

Done.

 
 namespace chrome {
 
 bool ToolkitViewsDialogsEnabled() {
   return base::CommandLine::ForCurrentProcess()->HasSwitch(
       switches::kEnableMacViewsDialogs);
 }
 
+void ShowWebsiteSettingsBubbleViewsAtPoint(const gfx::Point& anchor_point,
+                                           Profile* profile,
+                                           content::WebContents* web_contents,
+                                           const GURL& url,
+                                           const content::SSLStatus& ssl,
+                                           Browser* browser) {
+  // The views bubble requires an anchor views::View. Create one using the
+  // anchor point. Since the view doesn't have a container Widget,
+  // View::ConvertPointToScreen will assume it's origin is 0,0. Create a rect
+  // where the midpoint of the bottom edge is at the anchor point.
+  gfx::Rect anchor_view_rect(0, 0, anchor_point.x() * 2, anchor_point.y());
+  // WebsiteSettingsPopupView assumes a margin of
+  // WebsiteSettingsPopupView::kLocationIconVerticalMargin.
+  anchor_view_rect.Inset(0, 0, 0, -5);
+
+  views::View* anchor_view = new views::View();

[tapted, 2015/08/10 05:44:23]

memory leak?

This is going to be the hardest thing to fix.

Maybe we just inherit from WebsiteSettingsPopupView that deletes the view jammed
into the parent Widget when the popup is torn down (should be as easy as `delete
GetAnchorView();` -- I think the ViewStorage in BubbleDelegateView will return
null if the parent hierarcy somehow gets destroyed first).

Then roll a custom WebsiteSettingsPopupView::ShowPopup() for Mac -- there's not
much logic there and might help further decouple things.

[jackhou1, 2015/08/10 09:11:09]

We'd have to make InternalPageInfoPopupView public, which might not be that bad.
But I think we can just delete the anchor view when the bubble's widget goes
away.

+  anchor_view->SetBoundsRect(anchor_view_rect);
+  chrome::ShowWebsiteSettingsBubbleViews(anchor_view, profile, web_contents,
+                                         url, ssl, browser);
+}
+
 }  // namespace chrome