Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1280673002: Avoiding creation of new string for component version. (Closed)

Created:
5 years, 4 months ago by cmumford
Modified:
5 years, 4 months ago
Reviewers:
waffles
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoiding creation of new string for component version. base::Version constructor already takes a std::string, so no need to pass in result of c_str() which would just create a second std::string. Committed: https://crrev.com/c7a9315c7376b3d4664b03c57bcc295b11e46767 Cr-Commit-Position: refs/heads/master@{#342383}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/component_updater/default_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cmumford
5 years, 4 months ago (2015-08-06 16:10:16 UTC) #2
waffles
lgtm
5 years, 4 months ago (2015-08-07 16:27:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280673002/1
5 years, 4 months ago (2015-08-07 17:29:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 18:09:05 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:09:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7a9315c7376b3d4664b03c57bcc295b11e46767
Cr-Commit-Position: refs/heads/master@{#342383}

Powered by Google App Engine
This is Rietveld 408576698