Issue 1280633003: Fail with user friendly error when no new parent branch is specified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1280633003: Fail with user friendly error when no new parent branch is specified. (Closed)

Created:
5 years, 4 months ago by tandrii(chromium)

Modified:
5 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Fail with user friendly error when no new parent branch is specified. Before this change, running $ git reparent-branch produced stacktrace and "TypeError: sequence item 4: expected string, NoneType found" R=iannucci@chromium.org TEST=manual + unittest + coverage. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296235

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	git_reparent_branch.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tests/git_rebase_update_test.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280633003/1

5 years, 4 months ago (2015-08-06 17:55:18 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-06 17:57:15 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296235

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages