Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1280623002: Sample allocation rate in memory reducer. (Closed)

Created:
5 years, 4 months ago by ulan
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Sample allocation rate in memory reducer. Otherwise, if there is no GC and no idle notification, memory reducer will use old allocation rate. BUG=chromium:515873 LOG=NO Committed: https://crrev.com/ddcec9f6bf50779bc23bf43b731c0699cc19c4ea Cr-Commit-Position: refs/heads/master@{#30059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/heap/memory-reducer.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
ulan
PTAL
5 years, 4 months ago (2015-08-06 12:09:49 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 4 months ago (2015-08-06 12:28:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280623002/1
5 years, 4 months ago (2015-08-06 13:11:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4734)
5 years, 4 months ago (2015-08-06 13:14:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280623002/1
5 years, 4 months ago (2015-08-07 09:22:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 09:24:27 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 09:24:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddcec9f6bf50779bc23bf43b731c0699cc19c4ea
Cr-Commit-Position: refs/heads/master@{#30059}

Powered by Google App Engine
This is Rietveld 408576698