Source/core/layout/LayoutInline.h - Issue 1280543005: Refactor LayoutInline::addOutlineRects to avoid tricky logic to avoid dups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutInline.h

Issue 1280543005: Refactor LayoutInline::addOutlineRects to avoid tricky logic to avoid dups (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rephrase comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutInline.h

diff --git a/Source/core/layout/LayoutInline.h b/Source/core/layout/LayoutInline.h

index 3193e884662bf7f525567a3a755f191542531b9f..b24cdeab6d9ee413ecc36f0921e2ecc7f04e1797 100644

--- a/Source/core/layout/LayoutInline.h

+++ b/Source/core/layout/LayoutInline.h

@@ -87,6 +87,10 @@ public:

LayoutSize offsetForInFlowPositionedInline(const LayoutBox& child) const;

void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const final;

+ // The following methods are called from the container if it has already added outline rects for line boxes

+ // and/or children of this LayoutInline.

+ void addOutlineRectsForChildrenAndContinuations(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const;

+ void addOutlineRectsForContinuations(Vector<LayoutRect>&, const LayoutPoint& additionalOffset) const;

using LayoutBoxModelObject::continuation;

using LayoutBoxModelObject::setContinuation;

« no previous file with comments | « Source/core/layout/LayoutBoxModelObject.cpp ('k') | Source/core/layout/LayoutInline.cpp » ('j') | no next file with comments »