Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1280543004: Revert of Oilpan: catch some self-referential leaks (main thread.) (Closed)

Created:
5 years, 4 months ago by hiroshige
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: catch some self-referential leaks (main thread.) (patchset #7 id:120001 of https://codereview.chromium.org/1275863002/ ) Reason for revert: Breaking compilation on chromium trybots: error: use of undeclared identifier 'stderr' https://codereview.chromium.org/1277473003/ Original issue's description: > Oilpan: catch some self-referential leaks (main thread.) > > Track the number of SelfKeepAlive<>s that are currently active on > the main thread, so as to be able to detect if any remains on > shutdown. A clear indication of a leak, if so. > > Also add some debugging support for detecting thread shutdown > leaks due to Persistent<>s not being released; see > PersistentRegion::dumpLivePersistents() and ThreadState::cleanup(). > > R=haraken > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200163 TBR=oilpan-reviews@chromium.org,haraken@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -76 lines) Patch
M Source/platform/heap/Handle.h View 2 chunks +1 line, -9 lines 0 comments Download
M Source/platform/heap/PersistentNode.h View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/platform/heap/PersistentNode.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 5 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hiroshige
Created Revert of Oilpan: catch some self-referential leaks (main thread.)
5 years, 4 months ago (2015-08-07 14:23:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280543004/1
5 years, 4 months ago (2015-08-07 14:23:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=200168
5 years, 4 months ago (2015-08-07 14:23:34 UTC) #3
sof
lgtm, thanks.
5 years, 4 months ago (2015-08-07 14:33:36 UTC) #4
haraken
5 years, 4 months ago (2015-08-07 16:20:52 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698