Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 128053002: Make WebContentsDelegate::OpenColorChooser return NULL on failure (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 318f35beb62edabc7445841e8f39fd2c1a3858cf..df5a566eb02c14871ec70364b217051c7ebb76e8 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -335,7 +335,9 @@ class CONTENT_EXPORT WebContentsDelegate {
virtual JavaScriptDialogManager* GetJavaScriptDialogManager();
// Called when color chooser should open. Returns the opened color chooser.
- // Ownership of the returned pointer is transferred to the caller.
+ // Returns NULL if we failed to open the color chooser (e.g. when there is a
+ // ColorChooserDialog already open on Windows). Ownership of the returned
+ // pointer is transferred to the caller.
virtual ColorChooser* OpenColorChooser(
WebContents* web_contents,
SkColor color,
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698