Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools
Patch Set: review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
index fedeae774ba5650c8a8f37c9b7484000308df404..1ee0cc13699c38ffa70d93efd4c2e5ad32d3db17 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h
@@ -37,12 +37,16 @@ class GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {
static bool IsSizeValidForFormat(const gfx::Size& size,
gfx::BufferFormat format);
+ // Dumps GenericSharedMemory which backs this GpuMemoryBuffer.
+ static void DumpGenericSharedMemory(base::trace_event::ProcessMemoryDump* pmd,
+ uint64_t client_tracing_process_id,
+ gfx::GpuMemoryBufferId id);
reveman 2015/08/06 19:19:36 How about OnMemoryDump? And include size+format so
ericrk 2015/08/06 22:05:19 no longer applies.
+
// Overridden from gfx::GpuMemoryBuffer:
bool Map(void** data) override;
void Unmap() override;
void GetStride(int* stride) const override;
gfx::GpuMemoryBufferHandle GetHandle() const override;
-
reveman 2015/08/06 19:19:36 nit: keep this blank line
private:
GpuMemoryBufferImplSharedMemory(gfx::GpuMemoryBufferId id,
const gfx::Size& size,

Powered by Google App Engine
This is Rietveld 408576698