Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: ui/gfx/gpu_memory_buffer.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools
Patch Set: remove "tracing" from name Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/gpu_memory_buffer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/gpu_memory_buffer.cc
diff --git a/ui/gfx/gpu_memory_buffer.cc b/ui/gfx/gpu_memory_buffer.cc
index 44fcd31fd87513868f5d135d32393f7f92fc545d..9ccd41042578f9145d53b61b792c66bf1304b031 100644
--- a/ui/gfx/gpu_memory_buffer.cc
+++ b/ui/gfx/gpu_memory_buffer.cc
@@ -4,17 +4,16 @@
#include "ui/gfx/gpu_memory_buffer.h"
-#include "base/format_macros.h"
-#include "base/strings/stringprintf.h"
-
namespace gfx {
base::trace_event::MemoryAllocatorDumpGuid GetGpuMemoryBufferGUIDForTracing(
uint64 tracing_process_id,
GpuMemoryBufferId buffer_id) {
- return base::trace_event::MemoryAllocatorDumpGuid(
- base::StringPrintf("gpumemorybuffer-x-process/%" PRIx64 "/%d",
- tracing_process_id, buffer_id));
+ // TODO(ericrk): Currently this function just wraps
+ // GetGenericSharedMemoryGUIDForTracing, we may want to special case this if
+ // the GPU memory buffer is not backed by shared memory.
+ return gfx::GetGenericSharedMemoryGUIDForTracing(tracing_process_id,
+ buffer_id);
}
GpuMemoryBufferHandle::GpuMemoryBufferHandle()
« no previous file with comments | « ui/gfx/gpu_memory_buffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698