content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc - Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools

Patch Set: remove "tracing" from name Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc ('k') | content/common/gpu/gpu_memory_buffer_factory_io_surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc b/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

index 1ab1d99d4b9e168e134e381705fd24104444fa76..29fdd4447e539d4ad1b720df1c27daccd5987fad 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

@@ -50,7 +50,7 @@ class GpuMemoryBufferImplTest

};

TEST_P(GpuMemoryBufferImplTest, CreateFromHandle) {

- const int kBufferId = 1;

+ const gfx::GpuMemoryBufferId kBufferId(1);

gfx::Size buffer_size(8, 8);

@@ -73,7 +73,7 @@ TEST_P(GpuMemoryBufferImplTest, CreateFromHandle) {

}

TEST_P(GpuMemoryBufferImplTest, Map) {

- const int kBufferId = 1;

+ const gfx::GpuMemoryBufferId kBufferId(1);

// Use a multiple of 4 for both dimensions to support compressed formats.

gfx::Size buffer_size(4, 4);

@@ -135,7 +135,7 @@ TEST_P(GpuMemoryBufferImplTest, Map) {

}

TEST_P(GpuMemoryBufferImplTest, PersistentMap) {

- const int kBufferId = 1;

+ const gfx::GpuMemoryBufferId kBufferId(1);

// Use a multiple of 4 for both dimensions to support compressed formats.

gfx::Size buffer_size(4, 4);