content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc - Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools

Patch Set: Feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('K') | « content/common/generic_shared_memory_tracing_id_generator.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc » ('j') | ui/gfx/generic_shared_memory_tracing_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc b/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

index f16125bfa181f8e5bd51abfe54c0d48b3d453511..05c2b973d2d95e96c3044f6dd915487a9c5066a9 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc

@@ -47,7 +47,7 @@ scoped_ptr<GpuMemoryBufferImpl> GpuMemoryBufferImplIOSurface::CreateFromHandle(

gfx::BufferUsage usage,

const DestructionCallback& callback) {

base::ScopedCFTypeRef<IOSurfaceRef> io_surface(

- IOSurfaceManager::GetInstance()->AcquireIOSurface(handle.id));

+ IOSurfaceManager::GetInstance()->AcquireIOSurface(handle.id.id));

if (!io_surface)

return nullptr;