content/child/child_gpu_memory_buffer_manager.cc - Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/child_gpu_memory_buffer_manager.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools

Patch Set: Feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('K') | « content/browser/renderer_host/render_message_filter.cc ('k') | content/common/child_process_host_impl.h » ('j') | ui/gfx/generic_shared_memory_tracing_id.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/child_gpu_memory_buffer_manager.cc

diff --git a/content/child/child_gpu_memory_buffer_manager.cc b/content/child/child_gpu_memory_buffer_manager.cc

index 9a7517d7b8d358bc235e59fe81da4e0764b26c06..b7153e82003fe24318f42b4e7b808b1b946beb15 100644

--- a/content/child/child_gpu_memory_buffer_manager.cc

+++ b/content/child/child_gpu_memory_buffer_manager.cc

@@ -5,6 +5,7 @@

#include "content/child/child_gpu_memory_buffer_manager.h"

#include "content/common/child_process_messages.h"

+#include "content/common/generic_shared_memory_tracing_id_generator.h"

#include "content/common/gpu/client/gpu_memory_buffer_impl.h"

namespace content {

@@ -41,7 +42,8 @@ ChildGpuMemoryBufferManager::AllocateGpuMemoryBuffer(const gfx::Size& size,

gfx::GpuMemoryBufferHandle handle;

IPC::Message* message = new ChildProcessHostMsg_SyncAllocateGpuMemoryBuffer(

- size.width(), size.height(), format, usage, &handle);

+ content::GetNextGenericSharedMemoryTracingId(), size.width(),

+ size.height(), format, usage, &handle);

bool success = sender_->Send(message);

if (!success || handle.is_null())

return nullptr;