content/browser/browser_io_surface_manager_mac.h - Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_io_surface_manager_mac.h

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools

Patch Set: Feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/test/test_gpu_memory_buffer_manager.cc ('k') | content/browser/compositor/buffer_queue_unittest.cc » ('j') | content/browser/gpu/browser_gpu_memory_buffer_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_io_surface_manager_mac.h

diff --git a/content/browser/browser_io_surface_manager_mac.h b/content/browser/browser_io_surface_manager_mac.h

index 7d786eb0b0681ae5ff3a43827a713e9aed205bbd..6798e66684cb062d884cc6f478fb039060e3291a 100644

--- a/content/browser/browser_io_surface_manager_mac.h

+++ b/content/browser/browser_io_surface_manager_mac.h

@@ -24,6 +24,11 @@

namespace content {

+// TODO(ericrk): Use gfx::GenericSharedMemoryTracingId as the |io_surface_id| in

+// this file. Allows for more type-safe usage of GpuMemoryBufferIds as the

+// type of the |io_surface_id|, as it is a typedef of

+// gfx::GenericSharedMemoryTracingId.

// Implementation of IOSurfaceManager that provides a mechanism for child

// processes to register and acquire IOSurfaces through a Mach service.

class CONTENT_EXPORT BrowserIOSurfaceManager : public IOSurfaceManager {