cc/resources/resource_provider.cc - Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/resource_provider.cc

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools

Patch Set: Avoid double map lookup Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/memory/generic_shared_memory_id.cc ('k') | content/browser/gpu/browser_gpu_memory_buffer_manager.h » ('j') | content/browser/gpu/browser_gpu_memory_buffer_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/resources/resource_provider.cc

diff --git a/cc/resources/resource_provider.cc b/cc/resources/resource_provider.cc

index be282b9ae93d738b59629e2e5f07894ad6dc4179..a6ea1c97ac449e226453e6aa7405e9d8ca178892 100644

--- a/cc/resources/resource_provider.cc

+++ b/cc/resources/resource_provider.cc

@@ -9,6 +9,7 @@

#include "base/atomic_sequence_num.h"

#include "base/containers/hash_tables.h"

+#include "base/memory/generic_shared_memory_id.h"

#include "base/metrics/histogram.h"

#include "base/numerics/safe_math.h"

#include "base/stl_util.h"

@@ -2015,7 +2016,7 @@ bool ResourceProvider::OnMemoryDump(

// GpuMemoryBuffer, SharedBitmap, and GL backed resources.

base::trace_event::MemoryAllocatorDumpGuid guid;

if (resource.gpu_memory_buffer) {

- guid = gfx::GetGpuMemoryBufferGUIDForTracing(

+ guid = base::GetGenericSharedMemoryGUIDForTracing(

tracing_process_id, resource.gpu_memory_buffer->GetHandle().id);

} else if (resource.shared_bitmap) {

guid = GetSharedBitmapGUIDForTracing(resource.shared_bitmap->id());