content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h - Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

Issue 1280513002: Add GenericSharedMemoryId and use w/ GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@trackpools

Patch Set: Share GUID types between GpuMemoryBuffer and GenericSharedMemory Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/gpu/browser_gpu_memory_buffer_manager.cc ('K') | « content/common/generic_shared_memory_id_generator.cc ('k') | content/content_common.gypi » ('j') | ui/gfx/gpu_memory_buffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

index fedeae774ba5650c8a8f37c9b7484000308df404..767e06fba01916e16711148e821dead165580e32 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h

@@ -42,7 +42,6 @@ class GpuMemoryBufferImplSharedMemory : public GpuMemoryBufferImpl {

void Unmap() override;

void GetStride(int* stride) const override;

gfx::GpuMemoryBufferHandle GetHandle() const override;

piman 2015/08/06 23:29:12 nit: blank line should stay....

ericrk 2015/08/10 16:58:29 Done.

private:

GpuMemoryBufferImplSharedMemory(gfx::GpuMemoryBufferId id,

const gfx::Size& size,