net/cookies/canonical_cookie.h - Issue 12805010: Implementing EvictedDomainCookieCounter to keep user metrics on cookie eviction and reinstatement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/canonical_cookie.h

Issue 12805010: Implementing EvictedDomainCookieCounter to keep user metrics on cookie eviction and reinstatement. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanups; simplifying garbage collection; simplifying UMA; fixing off-by-1 meaning of max_size_. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/canonical_cookie.h

diff --git a/net/cookies/canonical_cookie.h b/net/cookies/canonical_cookie.h

index 88bc78879a742ff0dba89506f074cb5b3298bb2f..6c9a222805b47e435dc93f075756cc449920c5f4 100644

--- a/net/cookies/canonical_cookie.h

+++ b/net/cookies/canonical_cookie.h

@@ -82,7 +82,7 @@ class NET_EXPORT CanonicalCookie {

return !domain_.empty() && domain_[0] == '.'; }

bool IsHostCookie() const { return !IsDomainCookie(); }

- bool IsExpired(const base::Time& current) {

+ bool IsExpired(const base::Time& current) const {

return !expiry_date_.is_null() && current >= expiry_date_;

}

« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | net/cookies/cookie_monster.h » ('j') | net/cookies/evicted_domain_cookie_counter.h » ('J')