Issue 12805007: wd5-syncableServices for try only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12805007: wd5-syncableServices for try only (Closed)

Created:
7 years, 9 months ago by Jói

Modified:
7 years, 8 months ago

Reviewers:

CC:
chromium-reviews, Raman Kakilate, akalin, Raghu Simha, benquan, dhollowa+watch_chromium.org, amit, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, sail+watch_chromium.org, grt+watch_chromium.org, rginda+watch_chromium.org, robertshield, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, haitaol1, Ilya Sherman, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

wd5-syncableServices for try only BUG=none

Patch Set 1 #

Patch Set 2 : wd5-syncableServices_with_winfix #

Patch Set 3 : wd5-syncableServices with unit test fix #

Patch Set 4 : wd5-syncableServices with debug test fix #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1267 lines, -1092 lines)			Patch
M	chrome/browser/api/webdata/autofill_web_data_service.h	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/api/webdata/web_data_service_base.h	View		1 chunk	+96 lines, -4 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_browsertest.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/autofill_data_type_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc	View	1 2 3	7 chunks	+31 lines, -33 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_components_factory_impl.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_autofill_unittest.cc	View		8 chunks	+19 lines, -44 lines	0 comments	Download
M	chrome/browser/sync/test/integration/autofill_helper.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/autocomplete_syncable_service.h	View		3 chunks	+15 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/autocomplete_syncable_service.cc	View	1 2 3	6 chunks	+31 lines, -8 lines	0 comments	Download
M	chrome/browser/webdata/autofill_profile_syncable_service.h	View		4 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/autofill_profile_syncable_service.cc	View	1 2 3	3 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/autofill_table.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/autofill_table.cc	View	1	2 chunks	+22 lines, -7 lines	0 comments	Download
M	chrome/browser/webdata/autofill_table_unittest.cc	View		70 chunks	+178 lines, -292 lines	0 comments	Download
M	chrome/browser/webdata/autofill_web_data_service_impl.h	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/autofill_web_data_service_impl.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/keyword_table.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/keyword_table.cc	View	1	1 chunk	+18 lines, -4 lines	0 comments	Download
M	chrome/browser/webdata/keyword_table_unittest.cc	View		14 chunks	+34 lines, -55 lines	0 comments	Download
M	chrome/browser/webdata/logins_table.h	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/logins_table.cc	View	1	1 chunk	+22 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/token_service_table.h	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/token_service_table.cc	View	1	1 chunk	+22 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/token_service_table_unittest.cc	View		1 chunk	+22 lines, -24 lines	0 comments	Download
M	chrome/browser/webdata/web_apps_table.h	View		2 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/web_apps_table.cc	View	1	1 chunk	+22 lines, -1 line	0 comments	Download
M	chrome/browser/webdata/web_apps_table_unittest.cc	View		5 chunks	+19 lines, -18 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.h	View		5 chunks	+7 lines, -71 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service.cc	View		27 chunks	+43 lines, -174 lines	0 comments	Download
A	chrome/browser/webdata/web_data_service_base.cc	View	1 2	1 chunk	+135 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service_factory.h	View		2 chunks	+29 lines, -4 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service_factory.cc	View		6 chunks	+75 lines, -19 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service_test_util.h	View	1	2 chunks	+31 lines, -0 lines	0 comments	Download
A	chrome/browser/webdata/web_data_service_test_util.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_data_service_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/webdata/web_data_service_win.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/web_database.h	View		4 chunks	+19 lines, -29 lines	0 comments	Download
M	chrome/browser/webdata/web_database.cc	View		4 chunks	+16 lines, -57 lines	0 comments	Download
M	chrome/browser/webdata/web_database_migration_unittest.cc	View		30 chunks	+58 lines, -168 lines	0 comments	Download
M	chrome/browser/webdata/web_database_service.cc	View		3 chunks	+39 lines, -0 lines	0 comments	Download
M	chrome/browser/webdata/web_database_table.h	View		2 chunks	+18 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/web_database_table.cc	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/webdata/web_intents_table.cc	View	1	2 chunks	+24 lines, -5 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/base/testing_profile.cc	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	chrome_frame/test/delete_chrome_history_test.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	components/autofill/browser/DEPS	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	components/autofill/browser/autocomplete_history_manager.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	components/autofill/browser/autocomplete_history_manager_unittest.cc	View		5 chunks	+29 lines, -7 lines	0 comments	Download
M	components/autofill/browser/personal_data_manager.cc	View		12 chunks	+12 lines, -12 lines	0 comments	Download