Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1436)

Unified Diff: content/common/sandbox_init_win.cc

Issue 12805004: Remove mention of the nacl process in content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_init_win.cc
===================================================================
--- content/common/sandbox_init_win.cc (revision 188116)
+++ content/common/sandbox_init_win.cc (working copy)
@@ -18,24 +18,22 @@
std::string process_type =
command_line.GetSwitchValueASCII(switches::kProcessType);
sandbox::BrokerServices* broker_services = sandbox_info->broker_services;
- if (broker_services && !InitBrokerServices(broker_services))
- return false;
+ if (broker_services) {
+ if (!InitBrokerServices(broker_services))
+ return false;
- if (process_type.empty() || process_type == switches::kNaClBrokerProcess) {
// IMPORTANT: This piece of code needs to run as early as possible in the
// process because it will initialize the sandbox broker, which requires the
// process to swap its window station. During this time all the UI will be
// broken. This has to run before threads and windows are created.
- if (broker_services) {
- if (!command_line.HasSwitch(switches::kNoSandbox)) {
- bool use_winsta = !command_line.HasSwitch(
- switches::kDisableAltWinstation);
- // Precreate the desktop and window station used by the renderers.
- sandbox::TargetPolicy* policy = broker_services->CreatePolicy();
- sandbox::ResultCode result = policy->CreateAlternateDesktop(use_winsta);
- CHECK(sandbox::SBOX_ERROR_FAILED_TO_SWITCH_BACK_WINSTATION != result);
- policy->Release();
- }
+ if (!command_line.HasSwitch(switches::kNoSandbox)) {
+ bool use_winsta = !command_line.HasSwitch(
+ switches::kDisableAltWinstation);
+ // Precreate the desktop and window station used by the renderers.
+ sandbox::TargetPolicy* policy = broker_services->CreatePolicy();
+ sandbox::ResultCode result = policy->CreateAlternateDesktop(use_winsta);
+ CHECK(sandbox::SBOX_ERROR_FAILED_TO_SWITCH_BACK_WINSTATION != result);
+ policy->Release();
}
return true;
}
@@ -44,20 +42,6 @@
return true;
sandbox::TargetServices* target_services = sandbox_info->target_services;
- if ((process_type == switches::kRendererProcess) ||
- (process_type == switches::kWorkerProcess) ||
- (process_type == switches::kNaClLoaderProcess) ||
- (process_type == switches::kUtilityProcess)) {
- // The above five process types must be sandboxed unless --no-sandbox
- // is present in the command line.
- if (!target_services)
- return false;
- } else {
- // Other process types might or might not be sandboxed.
- // TODO(cpu): clean this mess.
- if (!target_services)
- return true;
- }
return InitTargetServices(target_services);
}

Powered by Google App Engine
This is Rietveld 408576698