storage/common/fileapi/file_system_util.cc - Issue 1280473002: Update ToLower/UpperASCII API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/common/fileapi/file_system_util.cc

Issue 1280473002: Update ToLower/UpperASCII API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: char16 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/common/fileapi/file_system_util.cc

diff --git a/storage/common/fileapi/file_system_util.cc b/storage/common/fileapi/file_system_util.cc

index 98b6cc81a4be8f51a0124bcde7607de1d58b7d88..16d74e44427dc58e683ff880f37bc06cae0cd32a 100644

--- a/storage/common/fileapi/file_system_util.cc

+++ b/storage/common/fileapi/file_system_util.cc

@@ -420,8 +420,8 @@ bool CrackIsolatedFileSystemName(const std::string& filesystem_name,

// names, so we do a case insensitive compare by converting both strings

// to uppercase.

// TODO(benwells): Remove this when WebKit uses the same constant.

- start_token = base::StringToUpperASCII(start_token);

- std::string filesystem_name_upper = base::StringToUpperASCII(filesystem_name);

+ start_token = base::ToUpperASCII(start_token);

+ std::string filesystem_name_upper = base::ToUpperASCII(filesystem_name);

size_t pos = filesystem_name_upper.find(start_token);

if (pos == std::string::npos)

return false;