net/http/http_auth_handler_ntlm_portable.cc - Issue 1280473002: Update ToLower/UpperASCII API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_auth_handler_ntlm_portable.cc

Issue 1280473002: Update ToLower/UpperASCII API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: char16 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_auth_handler_ntlm_portable.cc

diff --git a/net/http/http_auth_handler_ntlm_portable.cc b/net/http/http_auth_handler_ntlm_portable.cc

index 5e1d5faedc597ef451accefe14502ca49a4aebc1..54d4492a4bfd3d1564e42e046d6e36cb3e8303d4 100644

--- a/net/http/http_auth_handler_ntlm_portable.cc

+++ b/net/http/http_auth_handler_ntlm_portable.cc

@@ -261,7 +261,7 @@ static void LM_Hash(const base::string16& password, uint8* hash) {

// Convert password to OEM character set. We'll just use the native

// filesystem charset.

std::string passbuf = base::SysWideToNativeMB(base::UTF16ToWide(password));

- base::StringToUpperASCII(&passbuf);

+ passbuf = base::ToUpperASCII(passbuf);

passbuf.resize(14, '\0');

uint8 k1[8], k2[8];