extensions/renderer/runtime_custom_bindings.cc - Issue 1280473002: Update ToLower/UpperASCII API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/runtime_custom_bindings.cc

Issue 1280473002: Update ToLower/UpperASCII API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: char16 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/runtime_custom_bindings.cc

diff --git a/extensions/renderer/runtime_custom_bindings.cc b/extensions/renderer/runtime_custom_bindings.cc

index a7a5ff6cf4fd3b1262e4f56dae03e89506ed837d..c2e6500ae6c2f73b064a5fa16e27155582004aed 100644

--- a/extensions/renderer/runtime_custom_bindings.cc

+++ b/extensions/renderer/runtime_custom_bindings.cc

@@ -126,7 +126,7 @@ void RuntimeCustomBindings::GetExtensionViews(

int browser_window_id = args[0]->Int32Value();

std::string view_type_string = *v8::String::Utf8Value(args[1]);

- base::StringToUpperASCII(&view_type_string);

+ base::ToUpperASCII(&view_type_string);

// |view_type| == VIEW_TYPE_INVALID means getting any type of

// views.

ViewType view_type = VIEW_TYPE_INVALID;