content/browser/renderer_host/input/web_input_event_util.cc - Issue 1280473002: Update ToLower/UpperASCII API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_util.cc

Issue 1280473002: Update ToLower/UpperASCII API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/input/web_input_event_util.cc

diff --git a/content/browser/renderer_host/input/web_input_event_util.cc b/content/browser/renderer_host/input/web_input_event_util.cc

index ab4880739f248ff9d3fc83650c669eb83bebb351..973856df317f56eae24bd53967ecc08fc58ba346 100644

--- a/content/browser/renderer_host/input/web_input_event_util.cc

+++ b/content/browser/renderer_host/input/web_input_event_util.cc

@@ -153,10 +153,11 @@ void UpdateWindowsKeyCodeAndKeyIdentifier(blink::WebKeyboardEvent* event,

if (id) {

base::strlcpy(event->keyIdentifier, id, sizeof(event->keyIdentifier) - 1);

} else {

- base::snprintf(event->keyIdentifier,

- sizeof(event->keyIdentifier),

- "U+%04X",

- base::ToUpperASCII(static_cast<int>(windows_key_code)));

+ base::snprintf(

+ event->keyIdentifier,

+ sizeof(event->keyIdentifier),

+ "U+%04X",

+ base::ToUpperASCII(static_cast<base::char16>(windows_key_code)));

}