components/dom_distiller/core/viewer.cc - Issue 1280473002: Update ToLower/UpperASCII API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/core/viewer.cc

Issue 1280473002: Update ToLower/UpperASCII API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/dom_distiller/core/viewer.cc

diff --git a/components/dom_distiller/core/viewer.cc b/components/dom_distiller/core/viewer.cc

index 0a0dd546652d8a4f55390c407877255c1c548d25..7177cf6a726cceb616844a7e54bb652cb5121709 100644

--- a/components/dom_distiller/core/viewer.cc

+++ b/components/dom_distiller/core/viewer.cc

@@ -260,7 +260,7 @@ scoped_ptr<ViewerHandle> CreateViewRequest(

std::string entry_id =

url_utils::GetValueForKeyInUrlPathQuery(path, kEntryIdKey);

bool has_valid_entry_id = !entry_id.empty();

- entry_id = base::StringToUpperASCII(entry_id);

+ entry_id = base::ToUpperASCII(entry_id);

std::string requested_url_str =

url_utils::GetValueForKeyInUrlPathQuery(path, kUrlKey);