chrome/browser/push_messaging/push_messaging_app_identifier.cc - Issue 1280473002: Update ToLower/UpperASCII API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_app_identifier.cc

Issue 1280473002: Update ToLower/UpperASCII API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_app_identifier.cc

diff --git a/chrome/browser/push_messaging/push_messaging_app_identifier.cc b/chrome/browser/push_messaging/push_messaging_app_identifier.cc

index cfb8c5f1732b1d9a9f7c857acef0acd07b082c80..d21c50fbbbfe3c5b3411274c08ffc59d58d479b3 100644

--- a/chrome/browser/push_messaging/push_messaging_app_identifier.cc

+++ b/chrome/browser/push_messaging/push_messaging_app_identifier.cc

@@ -86,8 +86,7 @@ PushMessagingAppIdentifier PushMessagingAppIdentifier::FindByAppId(

DCHECK_EQ(kPushMessagingAppIdentifierPrefix, app_id.substr(0, kPrefixLength));

DCHECK_GE(app_id.size(), kPrefixLength + kGuidLength);

DCHECK_EQ(app_id.substr(app_id.size() - kGuidLength),

- base::StringToUpperASCII(

- app_id.substr(app_id.size() - kGuidLength)));

+ base::ToUpperASCII(app_id.substr(app_id.size() - kGuidLength)));

const base::DictionaryValue* map =

profile->GetPrefs()->GetDictionary(prefs::kPushMessagingAppIdentifierMap);