Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1280463003: Revert of Straightens outs DEPS in mojo/common (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, penghuang+watch-mandoline_chromium.org, feature-media-reviews_chromium.org, sdefresne+watchlist_chromium.org, qsr+mojo_chromium.org, droger+watchlist_chromium.org, Aaron Boodman, posciak+watch_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, media-router+watch_chromium.org, darin-cc_chromium.org, blundell+watchlist_chromium.org, darin (slow to review), wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Straightens outs DEPS in mojo/common (patchset #5 id:80001 of https://codereview.chromium.org/1262173005/ ) Reason for revert: Broke MediaRouterMojoImplTest.QueuedWhileAsleep on linux debug. Original issue's description: > Straightens outs DEPS in mojo/common > > Prior to this change //mojo/environment depended upon //mojo/common. //mojo/common's deps are wrong and it needs to be depend upon various things in //third_party/mojo/src/mojo... When these DEPS are added link errors result because Environment and and a couple of other things need to be defined. These are defined in //mojo/environment. But //mojo/environment can't be a dep of //mojo/common, else we get a cycle. > > To straighten this out I've moved the files //mojo/environment needs from //mojo/common to //mojo/message_pump. //mojo/environment no longer depends upon //mojo/common, only //mojo/message_pump. //mojo/common can then depend upon //mojo/environment and we no longer have the cycle. Yay! > > BUG=none > TEST=none > > Committed: https://crrev.com/a11b4d76a27816fe025af647825becac5f633c34 > Cr-Commit-Position: refs/heads/master@{#341979} TBR=jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/ad16cab0b66747137df714ff84c1338e352b7134 Cr-Commit-Position: refs/heads/master@{#342014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1735 lines, -1784 lines) Patch
M .gn View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_socket_handle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_url_loader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/message_port.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/message_port/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/message_port/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/message_port/web_message_port_channel_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/web_data_consumer_handle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_utility.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/javatests/mojo_test_case.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/android/system/base_run_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/cpp/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/lib/application_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application/public/cpp/lib/content_handler_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/BUILD.gn View 4 chunks +9 lines, -9 lines 0 comments Download
A mojo/common/handle_watcher.h View 1 chunk +64 lines, -0 lines 0 comments Download
A mojo/common/handle_watcher.cc View 1 chunk +475 lines, -0 lines 0 comments Download
A mojo/common/handle_watcher_unittest.cc View 1 chunk +483 lines, -0 lines 0 comments Download
A mojo/common/message_pump_mojo.h View 1 chunk +136 lines, -0 lines 0 comments Download
A mojo/common/message_pump_mojo.cc View 1 chunk +295 lines, -0 lines 0 comments Download
A mojo/common/message_pump_mojo_handler.h View 1 chunk +29 lines, -0 lines 0 comments Download
A mojo/common/message_pump_mojo_unittest.cc View 1 chunk +124 lines, -0 lines 0 comments Download
A mojo/common/time_helper.h View 1 chunk +34 lines, -0 lines 0 comments Download
A mojo/common/time_helper.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/environment/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/environment/default_async_waiter_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/message_pump/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/message_pump/handle_watcher.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/message_pump/handle_watcher.cc View 1 chunk +0 lines, -475 lines 0 comments Download
D mojo/message_pump/handle_watcher_unittest.cc View 1 chunk +0 lines, -483 lines 0 comments Download
D mojo/message_pump/message_pump_mojo.h View 1 chunk +0 lines, -135 lines 0 comments Download
D mojo/message_pump/message_pump_mojo.cc View 1 chunk +0 lines, -295 lines 0 comments Download
D mojo/message_pump/message_pump_mojo_handler.h View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/message_pump/message_pump_mojo_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D mojo/message_pump/time_helper.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/message_pump/time_helper.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M mojo/mojo_base.gyp View 7 chunks +15 lines, -31 lines 0 comments Download
M mojo/runner/BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download
M mojo/runner/android/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/child_process_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/network/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/http_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/web_socket_read_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/public/cpp/web_socket_write_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/url_loader_impl_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/web_socket_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Straightens outs DEPS in mojo/common
5 years, 4 months ago (2015-08-05 23:52:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280463003/1
5 years, 4 months ago (2015-08-05 23:53:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 23:55:02 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 23:55:54 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad16cab0b66747137df714ff84c1338e352b7134
Cr-Commit-Position: refs/heads/master@{#342014}

Powered by Google App Engine
This is Rietveld 408576698