Allow OpenCL to open libraries in /usr/lib

Allow OpenCL to open libraries in /usr/lib

BUG=508935
Committed: https://crrev.com/d387b682801d3d4ff7dd665b5238be2b335fb8c5
Cr-Commit-Position: refs/heads/master@{#342379}

[Greg K, 2015-08-05 22:30:09]

kerrnel@chromium.org changed reviewers:
+ rsesek@chromium.org

[Robert Sesek, 2015-08-05 22:35:58]

https://codereview.chromium.org/1280443003/diff/1/content/common/common.sb
File content/common/common.sb (right):

https://codereview.chromium.org/1280443003/diff/1/content/common/common.sb#ne...
content/common/common.sb:21: (define lion-or-later "LION_OR_LATER")
Move this down so that all the os version params are defined next to each other.

https://codereview.chromium.org/1280443003/diff/1/content/renderer/renderer.sb
File content/renderer/renderer.sb (right):

https://codereview.chromium.org/1280443003/diff/1/content/renderer/renderer.s...
content/renderer/renderer.sb:44: (regex #"^/usr/lib/libcurl(.4)?.dylib$")
Should you escape the periods here as literals, so they're not treated as
special?

[Greg K, 2015-08-06 00:17:10]

https://codereview.chromium.org/1280443003/diff/1/content/common/common.sb
File content/common/common.sb (right):

https://codereview.chromium.org/1280443003/diff/1/content/common/common.sb#ne...
content/common/common.sb:21: (define lion-or-later "LION_OR_LATER")
On 2015/08/05 22:35:58, Robert Sesek wrote:
> Move this down so that all the os version params are defined next to each
other.

Done.

https://codereview.chromium.org/1280443003/diff/1/content/renderer/renderer.sb
File content/renderer/renderer.sb (right):

https://codereview.chromium.org/1280443003/diff/1/content/renderer/renderer.s...
content/renderer/renderer.sb:44: (regex #"^/usr/lib/libcurl(.4)?.dylib$")
On 2015/08/05 22:35:58, Robert Sesek wrote:
> Should you escape the periods here as literals, so they're not treated as
> special?

I'm pretty sure that's what the # sign in front of the string does. It's not
really documented though. To make it simpler, I'll just make this a literal as
well. If it tries to open libcurl.dylib at some point, I'll update the sandbox
profile.

[Robert Sesek, 2015-08-07 16:21:59]

LGTM

[Greg K, 2015-08-07 17:24:27]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2015-08-07 17:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1280443003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1280443003/20001

[commit-bot: I haz the power, 2015-08-07 17:57:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-07 17:58:47]

Patchset 2 (id:??) landed as
https://crrev.com/d387b682801d3d4ff7dd665b5238be2b335fb8c5
Cr-Commit-Position: refs/heads/master@{#342379}