Source/core/css/resolver/SharedStyleFinder.cpp - Issue 1280423002: CSS4: Implement :placeholder-shown pseudo class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/SharedStyleFinder.cpp

Issue 1280423002: CSS4: Implement :placeholder-shown pseudo class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated as per review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/resolver/SharedStyleFinder.cpp

diff --git a/Source/core/css/resolver/SharedStyleFinder.cpp b/Source/core/css/resolver/SharedStyleFinder.cpp

index 8bee74f26697bbc567fb0fe408b0f8666b558224..75d3568ebc8a8b37453bf7f48c7785d2fbe12090 100644

--- a/Source/core/css/resolver/SharedStyleFinder.cpp

+++ b/Source/core/css/resolver/SharedStyleFinder.cpp

@@ -95,6 +95,9 @@ bool SharedStyleFinder::canShareStyleWithControl(Element& candidate) const

return false;

}

+ if (candidateInput.isPlaceholderVisible() != thisInput.isPlaceholderVisible())

+ return false;

return true;

}