Source/core/html/HTMLInputElement.cpp - Issue 1280423002: CSS4: Implement :placeholder-shown pseudo class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 1280423002: CSS4: Implement :placeholder-shown pseudo class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated testcase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 882662f2f642f8f380eb813e1460131e26dd9916..a4b87c097a7c96e002a9e3fd6f59e5b70bc50ec1 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -700,7 +700,7 @@ void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr

} else if (name == valueAttr) {

// We only need to setChanged if the form is looking at the default value right now.

if (!hasDirtyValue()) {

- updatePlaceholderVisibility(false);

+ updatePlaceholderVisibility();

setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::fromAttribute(valueAttr));

}

m_needsToUpdateViewValue = true;