cc: Save correct frame begin time to FrameRateCounter

cc/thread_proxy.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/thread_proxy.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "cc/context_provider.h"
@@ skipping 808 matching lines @@
     DCHECK(IsImplThread());
     DCHECK(m_layerTreeHostImpl.get());
     if (!m_layerTreeHostImpl.get())
         return result;
 
     DCHECK(m_layerTreeHostImpl->renderer());
     if (!m_layerTreeHostImpl->renderer())
         return result;
 
     // FIXME: compute the frame display time more intelligently
     base::TimeTicks monotonicTime = base::TimeTicks::Now();

[egraether, 2013/03/13 22:26:01]

There's another time here that could be replaced by lastVSyncTime, but I'm not
sure where this is going either.

     base::Time wallClockTime = base::Time::Now();
 
     if (m_inputHandlerOnImplThread.get())
         m_inputHandlerOnImplThread->animate(monotonicTime);
 
     m_layerTreeHostImpl->activatePendingTreeIfNeeded();
     m_layerTreeHostImpl->animate(monotonicTime, wallClockTime);
 
     // This method is called on a forced draw, regardless of whether we are able to produce a frame,
     // as the calling site on main thread is blocked until its request completes, and we signal
     // completion here. If canDraw() is false, we will indicate success=false to the caller, but we
     // must still signal completion to avoid deadlock.
 
     // We guard prepareToDraw() with canDraw() because it always returns a valid frame, so can only
     // be used when such a frame is possible. Since drawLayers() depends on the result of
     // prepareToDraw(), it is guarded on canDraw() as well.
 
     LayerTreeHostImpl::FrameData frame;
     bool drawFrame = m_layerTreeHostImpl->canDraw() && (m_layerTreeHostImpl->prepareToDraw(frame) || forcedDraw);

[nduca, 2013/03/13 05:53:28]

i think we should pass the lastVsynctime to animate as well...


can you also fix the routing in threadproxy for beginFrameAndCommit's timestamp?
that should also be lastVSyncTime instead of now...

[egraether, 2013/03/13 22:26:01]

I think you are right, but I'm not sure what side effects this could cause.
Maybe it's better to do this in another patch.

     if (drawFrame) {
-        m_layerTreeHostImpl->drawLayers(frame);
+        m_layerTreeHostImpl->drawLayers(frame, m_schedulerOnImplThread->lastDrawTime());
         result.didDraw = true;
     }
     m_layerTreeHostImpl->didDrawAllLayers(frame);
 
     // Check for tree activation.
     if (m_completionEventForCommitHeldOnTreeActivation && !m_layerTreeHostImpl->pendingTree())
     {
         TRACE_EVENT_INSTANT0("cc", "ReleaseCommitbyActivation");
         DCHECK(m_layerTreeHostImpl->Settings().implSidePainting);
         m_completionEventForCommitHeldOnTreeActivation->signal();
@@ skipping 368 matching lines @@
 
 void ThreadProxy::renewTreePriorityOnImplThread()
 {
     DCHECK(m_renewTreePriorityOnImplThreadPending);
     m_renewTreePriorityOnImplThreadPending = false;
 
     renewTreePriority();
 }
 
 }  // namespace cc