Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 1280343002: Copy files for splitting src/compiler.dart into several libraries (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy files for splitting src/compiler.dart into several libraries Intended future content: common/backend_api.dart: Backend common/codegen.dart: CodegenRegistry CodegenWorkItem common/registry.dart: Registry common/resolution.dart: ResolutionCallbacks ResolutionWorkItem common/tasks.dart: CompilerTask DeferredAction DeferredTask, GenericTask common/work.dart: ItemCompilationContext WorkItem diagnostics/code_location.dart: AnyLocation CodeLocation PackageLocation SchemeLocation diagnostics/invariant.dart: DEBUG_MODE assertDebugMode invariant REPORT_EXCESS_RESOLUTION diagnostics/source_span.dart SourceSpan diagnostics/spannable.dart Spannable (from util/util.dart) NO_LOCATION_SPANNABLE (from util/util.dart) CURRENT_ELEMENT_SPANNABLE (from util/util.dart) scanner/token_map: TokenKey TokenMap BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1d0bc4b94ee8050fde64a4459a371aad781a2b71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-11 lines, --11 lines) Patch
A + pkg/compiler/lib/src/common/backend_api.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/common/codegen.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/common/registry.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/common/resolution.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/common/tasks.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/common/work.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/diagnostics/code_location.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/diagnostics/invariant.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/diagnostics/source_span.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/diagnostics/spannable.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/compiler/lib/src/scanner/token_map.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
5 years, 4 months ago (2015-08-10 14:46:23 UTC) #2
Siggi Cherem (dart-lang)
lgtm - is the copy to make it easier to track history? I'd be fine ...
5 years, 4 months ago (2015-08-10 16:28:59 UTC) #4
Johnni Winther
On 2015/08/10 16:28:59, Siggi Cherem (dart-lang) wrote: > lgtm - is the copy to make ...
5 years, 4 months ago (2015-08-11 07:52:04 UTC) #5
Johnni Winther
5 years, 4 months ago (2015-08-11 08:57:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d0bc4b94ee8050fde64a4459a371aad781a2b71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698