Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 128033004: Fix the policy-pushed-certs omnibox icon. (Closed)

Created:
6 years, 11 months ago by dconnelly
Modified:
6 years, 11 months ago
Reviewers:
dconnelly1, oshima, sky
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Fix the policy-pushed-certs omnibox icon. Screenshot on the bug. BUG=276956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243608

Patch Set 1 #

Total comments: 2

Patch Set 2 : keep the resource ID #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
D chrome/app/theme/default_100_percent/common/omnibox_https_policy_warning.png View Binary file 0 comments Download
D chrome/app/theme/default_200_percent/common/omnibox_https_policy_warning.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dconnelly
Hi guys, sky: please look at chrome/browser/ui/toolbar oshima: chrome/app/theme Thanks!
6 years, 11 months ago (2014-01-08 13:44:53 UTC) #1
sky
https://codereview.chromium.org/128033004/diff/1/chrome/browser/ui/toolbar/toolbar_model_impl.cc File chrome/browser/ui/toolbar/toolbar_model_impl.cc (right): https://codereview.chromium.org/128033004/diff/1/chrome/browser/ui/toolbar/toolbar_model_impl.cc#newcode224 chrome/browser/ui/toolbar/toolbar_model_impl.cc:224: IDR_CONTROLLED_SETTING_MANDATORY, I think it better to keep the name ...
6 years, 11 months ago (2014-01-08 15:17:44 UTC) #2
dconnelly
https://codereview.chromium.org/128033004/diff/1/chrome/browser/ui/toolbar/toolbar_model_impl.cc File chrome/browser/ui/toolbar/toolbar_model_impl.cc (right): https://codereview.chromium.org/128033004/diff/1/chrome/browser/ui/toolbar/toolbar_model_impl.cc#newcode224 chrome/browser/ui/toolbar/toolbar_model_impl.cc:224: IDR_CONTROLLED_SETTING_MANDATORY, On 2014/01/08 15:17:44, sky wrote: > I think ...
6 years, 11 months ago (2014-01-08 15:35:27 UTC) #3
sky
Thanks, LGTM
6 years, 11 months ago (2014-01-08 15:40:23 UTC) #4
oshima
lgtm
6 years, 11 months ago (2014-01-08 15:44:57 UTC) #5
oshima
lgtm
6 years, 11 months ago (2014-01-08 15:44:59 UTC) #6
dconnelly1
thanks guys! On Wed, Jan 8, 2014 at 4:44 PM, <oshima@chromium.org> wrote: > lgtm > ...
6 years, 11 months ago (2014-01-08 15:45:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/128033004/50001
6 years, 11 months ago (2014-01-08 15:46:09 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 18:38:19 UTC) #9
Message was sent while issue was closed.
Change committed as 243608

Powered by Google App Engine
This is Rietveld 408576698