[Files.app] Use 'activate' event on the view-change menuitems instead of 'click' event

[Files.app] Use 'activate' event on the view-change menuitems instead of 'click' event

A 'click' event can't be handle an activation by keyboard.

BUG=329166
TEST=manually tested

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245200

[yoshiki, 2014-01-08 11:31:59]

@hirono, PTAL. Thanks.

[hirono, 2014-01-09 03:12:09]

On 2014/01/08 11:31:59, yoshiki wrote:
> @hirono, PTAL. Thanks.

Sorry this is due to my change.
Please check the crbug.com/248479 also does not happens after applying your
patch?

[yoshiki, 2014-01-09 07:09:15]

@hirono: Fixed the issue of crbug.com/248479. PTAL again?

[hirono, 2014-01-09 07:18:20]

On 2014/01/09 07:09:15, yoshiki wrote:
> @hirono: Fixed the issue of crbug.com/248479. PTAL again?

Thanks a ton. lgtm!

[commit-bot: I haz the power, 2014-01-09 07:19:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/128023002/40001

[commit-bot: I haz the power, 2014-01-10 05:25:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/128023002/40001

[commit-bot: I haz the power, 2014-01-10 08:33:28]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-10 14:52:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/128023002/40001

[commit-bot: I haz the power, 2014-01-10 18:11:15]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-16 05:47:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/128023002/530001

[commit-bot: I haz the power, 2014-01-16 05:47:46]

Failed to apply patch for
chrome/browser/resources/file_manager/background/js/test_util.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/file_manager/background/js/test_util.js
  Hunk #1 FAILED at 581.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/resources/file_manager/background/js/test_util.js.rej

Patch:       chrome/browser/resources/file_manager/background/js/test_util.js
Index: chrome/browser/resources/file_manager/background/js/test_util.js
diff --git a/chrome/browser/resources/file_manager/background/js/test_util.js
b/chrome/browser/resources/file_manager/background/js/test_util.js
index
04a3f92b9cb8e506772de4b9554234c3a40fff72..582dc44212edca55eeeb70ba65a0aa121a4f0e0c
100644
--- a/chrome/browser/resources/file_manager/background/js/test_util.js
+++ b/chrome/browser/resources/file_manager/background/js/test_util.js
@@ -581,19 +581,31 @@ test.util.sync.fakeKeyDown = function(
 };
 
 /**
- * Sends a fake mouse click event (left button, single click) to the element
- * specified by |targetQuery|.
+ * Simulates a fake mouse click (left button, single click) on the element
+ * specified by |targetQuery|. This sends 'mouseover', 'mousedown', 'mouseup'
+ * and 'click' events in turns.
  *
  * @param {Window} contentWindow Window to be tested.
  * @param {string} targetQuery Query to specify the element.
  * @param {string=} opt_iframeQuery Optional iframe selector.
- * @return {boolean} True if the event is sent to the target, false otherwise.
+ * @return {boolean} True if the all events are sent to the target, false
+ *     otherwise.
  */
 test.util.sync.fakeMouseClick = function(
     contentWindow, targetQuery, opt_iframeQuery) {
-  var event = new MouseEvent('click', { bubbles: true, detail: 1 });
-  return test.util.sync.sendEvent(
-      contentWindow, targetQuery, event, opt_iframeQuery);
+  var mouseOverEvent = new MouseEvent('mouseover', {bubbles: true, detail: 1});
+  var resultMouseOver = test.util.sync.sendEvent(
+      contentWindow, targetQuery, mouseOverEvent, opt_iframeQuery);
+  var mouseDownEvent = new MouseEvent('mousedown', {bubbles: true, detail: 1});
+  var resultMouseDown = test.util.sync.sendEvent(
+      contentWindow, targetQuery, mouseDownEvent, opt_iframeQuery);
+  var mouseUpEvent = new MouseEvent('mouseup', {bubbles: true, detail: 1});
+  var resultMouseUp = test.util.sync.sendEvent(
+      contentWindow, targetQuery, mouseUpEvent, opt_iframeQuery);
+  var clickEvent = new MouseEvent('click', {bubbles: true, detail: 1});
+  var resultClick = test.util.sync.sendEvent(
+      contentWindow, targetQuery, clickEvent, opt_iframeQuery);
+  return resultMouseOver && resultMouseDown && resultMouseUp && resultClick;
 };
 
 /**

[commit-bot: I haz the power, 2014-01-16 12:46:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/128023002/600001

[commit-bot: I haz the power, 2014-01-16 15:48:08]

Change committed as 245200