chrome/browser/resources/ntp4/new_tab.js - Issue 128013002: Fix apps page footer shrinking/overlap for small window sizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 128013002: Fix apps page footer shrinking/overlap for small window sizes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/ntp4/new_tab.js

diff --git a/chrome/browser/resources/ntp4/new_tab.js b/chrome/browser/resources/ntp4/new_tab.js

index 30cfab672ce7f99b65a9fec4a7c709da078df5b6..af7b79c1c2cc1ebdad4b75d834684a5bc63e6673 100644

--- a/chrome/browser/resources/ntp4/new_tab.js

+++ b/chrome/browser/resources/ntp4/new_tab.js

@@ -709,6 +709,12 @@ cr.define('ntp', function() {

};

});

-document.addEventListener('DOMContentLoaded', ntp.onLoad);

+document.addEventListener('DOMContentLoaded', function() {

+ var logo = $('logo-img').querySelector('img');

+ if (logo.complete)

+ ntp.onLoad();

+ else

+ logo.addEventListener('load', ntp.onLoad);

+});

Dan Beam 2014/01/09 18:58:19 ^ you should not block the whole NTP on this.

dconnelly 2014/01/10 10:46:57 Done.

var toCssPx = cr.ui.toCssPx;

« no previous file with comments | « chrome/browser/resources/ntp4/new_tab.css ('k') | no next file » | no next file with comments »