Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 128013002: Fix apps page footer shrinking/overlap for small window sizes. (Closed)

Created:
6 years, 11 months ago by dconnelly
Modified:
6 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Visibility:
Public.

Description

Fix apps page footer shrinking/overlap for small window sizes. This CL shrinks the logo instead of hiding the nav dots and makes the nav dots shrink to the same size by using the new*** flexbox spec. It also delays dot layout until the footer logo is loaded as this is necessary for accurate measurements. BUG=332350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244486

Patch Set 1 : #

Total comments: 4

Patch Set 2 : delay layoutFooter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/resources/ntp4/nav_dot.css View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dconnelly
6 years, 11 months ago (2014-01-08 12:08:31 UTC) #1
dconnelly
6 years, 11 months ago (2014-01-08 13:46:10 UTC) #2
dconnelly
dbeam: PTAL
6 years, 11 months ago (2014-01-08 14:06:38 UTC) #3
Dan Beam
https://codereview.chromium.org/128013002/diff/20003/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): https://codereview.chromium.org/128013002/diff/20003/chrome/browser/resources/ntp4/new_tab.js#newcode131 chrome/browser/resources/ntp4/new_tab.js:131: measureNavDots(); ^ you could do it here https://codereview.chromium.org/128013002/diff/20003/chrome/browser/resources/ntp4/new_tab.js#newcode359 chrome/browser/resources/ntp4/new_tab.js:359: ...
6 years, 11 months ago (2014-01-09 18:58:19 UTC) #4
dconnelly
https://codereview.chromium.org/128013002/diff/20003/chrome/browser/resources/ntp4/new_tab.js File chrome/browser/resources/ntp4/new_tab.js (right): https://codereview.chromium.org/128013002/diff/20003/chrome/browser/resources/ntp4/new_tab.js#newcode718 chrome/browser/resources/ntp4/new_tab.js:718: }); On 2014/01/09 18:58:19, Dan Beam wrote: > ^ ...
6 years, 11 months ago (2014-01-10 10:46:57 UTC) #5
Dan Beam
lgtm
6 years, 11 months ago (2014-01-10 21:48:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/128013002/100001
6 years, 11 months ago (2014-01-13 08:03:31 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 12:03:44 UTC) #8
Message was sent while issue was closed.
Change committed as 244486

Powered by Google App Engine
This is Rietveld 408576698