Don't allow whitespace between elements with display:table-cell

Source/core/layout/LayoutTableRow.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 87 matching lines @@
     return style()->borderStart();
 }
 
 const BorderValue& LayoutTableRow::borderAdjoiningEndCell(const LayoutTableCell* cell) const
 {
     ASSERT_UNUSED(cell, cell->isFirstOrLastCellInRow());
     // FIXME: https://webkit.org/b/79272 - Add support for mixed directionality at the cell level.
     return style()->borderEnd();
 }
 
+void LayoutTableRow::createAndAddAnonymousCell(LayoutObject* child, LayoutObject* beforeChild)
+{
+    LayoutTableCell* cell = LayoutTableCell::createAnonymousWithParent(this);
+    addChild(cell, beforeChild);
+    cell->addChild(child);
+}
+
 void LayoutTableRow::addChild(LayoutObject* child, LayoutObject* beforeChild)
 {
     if (!child->isTableCell()) {
+        if (child->style()->display() == TABLE_CELL) {
+            createAndAddAnonymousCell(child, beforeChild);

[esprehn, 2015/08/17 17:58:54]

This doesn't feel like a good idea, does the input actually claim it has
display: table-cell even though we ignore it?

[rhogan, 2015/08/17 18:16:57]

We don't ignore it anymore (see below in LayoutTheme.cpp) but we don't act on it
to create a table cell. Instead we wrap the form object in anonymous table cell.

[esprehn, 2015/08/17 18:27:08]

Yeah I don't think that's a good idea, it means there's elements in the page
claiming they're tables that aren't and don't really respect the table
properties.

+            return;
+        }
+
         LayoutObject* last = beforeChild;
         if (!last)
             last = lastCell();
         if (last && last->isAnonymous() && last->isTableCell() && !last->isBeforeOrAfterContent()) {
             LayoutTableCell* lastCell = toLayoutTableCell(last);
             if (beforeChild == lastCell)
                 beforeChild = lastCell->firstChild();
             lastCell->addChild(child, beforeChild);
             return;
         }
 
         if (beforeChild && !beforeChild->isAnonymous() && beforeChild->parent() == this) {
             LayoutObject* cell = beforeChild->previousSibling();
             if (cell && cell->isTableCell() && cell->isAnonymous()) {
                 cell->addChild(child);
                 return;
             }
         }
 
         // If beforeChild is inside an anonymous cell, insert into the cell.
         if (last && !last->isTableCell() && last->parent() && last->parent()->isAnonymous() && !last->parent()->isBeforeOrAfterContent()) {
             last->parent()->addChild(child, beforeChild);
             return;
         }
 
-        LayoutTableCell* cell = LayoutTableCell::createAnonymousWithParent(this);
-        addChild(cell, beforeChild);
-        cell->addChild(child);
+        createAndAddAnonymousCell(child, beforeChild);
         return;
     }
 
     if (beforeChild && beforeChild->parent() != this)
         beforeChild = splitAnonymousBoxesAroundChild(beforeChild);
 
     LayoutTableCell* cell = toLayoutTableCell(child);
 
     // Generated content can result in us having a null section so make sure to null check our parent.
     if (parent())
@@ skipping 101 matching lines @@
     // The cell and the row share the section's coordinate system. However
     // the visual overflow should be determined in the coordinate system of
     // the row, that's why we shift it below.
     LayoutUnit cellOffsetLogicalTopDifference = cell->location().y() - location().y();
     cellVisualOverflowRect.move(0, cellOffsetLogicalTopDifference);
 
     addVisualOverflow(cellVisualOverflowRect);
 }
 
 } // namespace blink