Don't allow whitespace between elements with display:table-cell

Source/core/dom/Text.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 227 matching lines @@
     return cloneWithData(data());
 }
 
 static inline bool hasGeneratedAnonymousTableCells(const LayoutObject& parent)
 {
     // We're checking whether the table part has generated anonymous table
     // part wrappers to hold its contents, so inspecting its first child will suffice.
     LayoutObject* child = parent.slowFirstChild();
     if (!child || !child->isAnonymous())
         return false;
-    if (child->isTableCell()) {
-        LayoutObject* firstChild = child->slowFirstChild();
-        // Ignore the anonymous table cell if it is wrapping a table cell element (e.g. because of <td style="display:block;">).
-        return !firstChild || !firstChild->node() || !isHTMLTableCellElement(firstChild->node());
-    }
+    if (child->isTableCell())
+        return true;
     if (child->isTableSection() || child->isTableRow())
         return hasGeneratedAnonymousTableCells(*child);
     return false;
 }
 
-static inline bool canHaveWhitespaceChildren(const LayoutObject& parent)
+static inline bool nodeAllowsWhitespace(Node* node)

[mstensho (USE GERRIT), 2015/08/26 18:45:56]

How about nodeAllowsAdjacentWhitespace() or something, just to make sure that
nobody thinks it's about whitespace _inside_ the node?

+{
+    if (!node)
+        return true;
+    const ComputedStyle* style = node->ensureComputedStyle();
+    return style && style->originalDisplay() != TABLE_CELL && !isHTMLTableCellElement(node);
+}
+
+static inline bool canHaveWhitespaceChildren(const LayoutObject& parent, Node* node)

[mstensho (USE GERRIT), 2015/08/26 18:45:56]

|node| should be of type Text* (and probably be named |text| or |textChild|).

 {
     // <button> should allow whitespace even though LayoutFlexibleBox doesn't.
     if (parent.isLayoutButton())
         return true;
 
     // Allow whitespace when the text is inside a table, section or row element that
     // has generated anonymous table cells to hold its contents.
     if (hasGeneratedAnonymousTableCells(parent))

[mstensho (USE GERRIT), 2015/08/26 18:45:56]

Can we move this block inside the "if (parent.isTable() || parent.isTableRow()
|| parent.isALotOfThings()...)" block? No need to execute it otherwise.

OK, this has nothing to do with this patch, strictly speaking, so maybe for a
follow-up CL? Or whatever you prefer. :)

-        return true;
+        return nodeAllowsWhitespace(node->previousSibling()) && nodeAllowsWhitespace(node->nextSibling());
 
     if (parent.isTable() || parent.isTableRow() || parent.isTableSection()
         || parent.isLayoutTableCol() || parent.isFrameSet()
         || parent.isFlexibleBox() || parent.isLayoutGrid()
         || parent.isSVGRoot()
         || parent.isSVGContainer()
         || parent.isSVGImage()
         || parent.isSVGShape())
         return false;
     return true;
 }
 
 bool Text::textLayoutObjectIsNeeded(const ComputedStyle& style, const LayoutObject& parent)
 {
     if (!parent.canHaveChildren())
         return false;
 
     if (isEditingText())
         return true;
 
     if (!length())
         return false;
 
     if (style.display() == NONE)
         return false;
 
     if (!containsOnlyWhitespace())
         return true;
 
-    if (!canHaveWhitespaceChildren(parent))
+    if (!canHaveWhitespaceChildren(parent, this))
         return false;
 
     // pre-wrap in SVG never makes layoutObject.
     if (style.whiteSpace() == PRE_WRAP && parent.isSVG())
         return false;
 
     // pre/pre-wrap/pre-line always make layoutObjects.
     if (style.preserveNewline())
         return true;
 
@@ skipping 148 matching lines @@
             result.appendLiteral("; ");
         result.appendLiteral("value=");
         result.append(s);
     }
 
     strncpy(buffer, result.toString().utf8().data(), length - 1);
 }
 #endif
 
 } // namespace blink