Issue 12801002: Modifying the behavior of render_pictures --validate to test the effect of bbh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12801002: Modifying the behavior of render_pictures --validate to test the effect of bbh. (Closed)

Created:
7 years, 9 months ago by Justin Novosad

Modified:
7 years, 9 months ago

Reviewers:
edisonn, borenet

CC:
skia-review_googlegroups.com, reed1, robertphillips

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Modifying the behavior of render_pictures --validate to test the effect of bbh. The new behavior consists in using the same renderer, with bbh disabled, as a reference renderer when the current renderer has a bbh. Committed: https://code.google.com/p/skia/source/detail?r=8132

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -3 lines)			Patch
	M	tools/PictureRenderer.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tools/render_pictures_main.cpp	View	1 2	3 chunks	+43 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

borenet

LGTM but adding Edi since he wrote the original validate code.

7 years, 9 months ago (2013-03-13 12:44:05 UTC) #2

edisonn

https://codereview.chromium.org/12801002/diff/4001/tools/render_pictures_main.cpp File tools/render_pictures_main.cpp (right): https://codereview.chromium.org/12801002/diff/4001/tools/render_pictures_main.cpp#newcode37 tools/render_pictures_main.cpp:37: DEFINE_bool(validate, false, "Verify that the rendered image contains the ...

7 years, 9 months ago (2013-03-13 15:25:34 UTC) #3

LGTM

Expand Messages | Collapse Messages