Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1280033002: Revert of Add channel-specific product logo to chrome://help (Closed)

Created:
5 years, 4 months ago by tommi (sloooow) - chröme
Modified:
5 years, 4 months ago
Reviewers:
oshima, Dan Beam, Evan Stade
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add channel-specific product logo to chrome://help (patchset #3 id:40001 of https://codereview.chromium.org/1269383005/ ) Reason for revert: Reverting due to missing files. See comments in cl: https://codereview.chromium.org/1269383005/ Original issue's description: > Add channel-specific product logo to chrome://help > > BUG=511000 > > Committed: https://crrev.com/9836302ea4ffb887ce6ffa597c1ee5484d2f1091 > Cr-Commit-Position: refs/heads/master@{#342183} TBR=oshima@chromium.org,dbeam@chromium.org,estade@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511000 Committed: https://crrev.com/abd20f67987aaa47bb47e61288ec92b4ab761521 Cr-Commit-Position: refs/heads/master@{#342324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M chrome/app/theme/theme_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/help/help_content.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/help_ui.cc View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tommi (sloooow) - chröme
Created Revert of Add channel-specific product logo to chrome://help
5 years, 4 months ago (2015-08-07 09:27:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280033002/1
5 years, 4 months ago (2015-08-07 09:28:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 09:28:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abd20f67987aaa47bb47e61288ec92b4ab761521 Cr-Commit-Position: refs/heads/master@{#342324}
5 years, 4 months ago (2015-08-07 09:29:23 UTC) #4
Evan Stade
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1279093002/ by estade@chromium.org. ...
5 years, 4 months ago (2015-08-07 17:20:11 UTC) #5
tommi (sloooow) - chröme
On 2015/08/07 17:20:11, Evan Stade wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 4 months ago (2015-08-09 18:02:02 UTC) #6
Evan Stade
On 2015/08/09 18:02:02, tommi wrote: > On 2015/08/07 17:20:11, Evan Stade wrote: > > A ...
5 years, 4 months ago (2015-08-10 16:12:15 UTC) #7
tommi (sloooow) - chröme
5 years, 4 months ago (2015-08-10 16:25:26 UTC) #8
Message was sent while issue was closed.
On 2015/08/10 16:12:15, Evan Stade wrote:
> On 2015/08/09 18:02:02, tommi wrote:
> > On 2015/08/07 17:20:11, Evan Stade wrote:
> > > A revert of this CL (patchset #1 id:1) has been created in
> > > https://codereview.chromium.org/1279093002/ by mailto:estade@chromium.org.
> > > 
> > > The reason for reverting is: Official build bots were all happy with the
> > change
> > > --- suspect the issue was a local config problem (such as not updating
> > > src-internal)..
> > 
> > Hmm... that was not it... the files really looked missing. I'll check again.
> 
> thanks, let me know if problems remain.

Everything is fine now.  It must have been pilot error then. Sorry about the
revert.

Powered by Google App Engine
This is Rietveld 408576698