Added policy to disable/enable a system log upload.

chrome/browser/chromeos/settings/device_settings_provider_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 81 matching lines @@
     em::DeviceHeartbeatSettingsProto* proto =
         device_policy_.payload().mutable_device_heartbeat_settings();
     proto->set_heartbeat_enabled(enable_heartbeat);
     proto->set_heartbeat_frequency(frequency);
     device_policy_.Build();
     device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
     ReloadDeviceSettings();
     Mock::VerifyAndClearExpectations(this);
   }
 
+  // Helper routine to enable/disable log upload settings in policy.
+  void SetLogUploadSettings(bool enable_log_upload) {
+    EXPECT_CALL(*this, SettingChanged(_)).Times(AtLeast(1));
+    em::DeviceLogUploadSettingsProto* proto =
+        device_policy_.payload().mutable_device_log_upload_settings();
+    proto->set_log_upload_enabled(enable_log_upload);
+    device_policy_.Build();
+    device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
+    ReloadDeviceSettings();
+    Mock::VerifyAndClearExpectations(this);
+  }
+
   // Helper routine to ensure all heartbeat policies have been correctly
   // decoded.
   void VerifyHeartbeatSettings(bool expected_enable_state,
                                int expected_frequency) {
 
     const base::FundamentalValue expected_enabled_value(expected_enable_state);
     EXPECT_TRUE(base::Value::Equals(provider_->Get(kHeartbeatEnabled),
                                     &expected_enabled_value));
 
     const base::FundamentalValue expected_frequency_value(expected_frequency);
@@ skipping 21 matching lines @@
     for (const auto& setting : reporting_settings) {
       EXPECT_TRUE(base::Value::Equals(provider_->Get(setting),
                                       &expected_enable_value))
           << "Value for " << setting << " does not match expected";
     }
     const base::FundamentalValue expected_frequency_value(expected_frequency);
     EXPECT_TRUE(base::Value::Equals(provider_->Get(kReportUploadFrequency),
                                     &expected_frequency_value));
   }
 
+  // Helper routine to ensure log upload policy has been correctly
+  // decoded.
+  void VerifyLogUploadSettings(bool expected_enable_state) {
+    const base::FundamentalValue expected_enabled_value(expected_enable_state);
+    EXPECT_TRUE(base::Value::Equals(provider_->Get(kLogUploadEnabled),
+                                    &expected_enabled_value));
+  }
+
   // Helper routine to set LoginScreenDomainAutoComplete policy.
   void SetDomainAutoComplete(const std::string& domain) {
     EXPECT_CALL(*this, SettingChanged(_)).Times(AtLeast(1));
     em::LoginScreenDomainAutoCompleteProto* proto =
         device_policy_.payload().mutable_login_screen_domain_auto_complete();
     proto->set_login_screen_domain_auto_complete(domain);
     device_policy_.Build();
     device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
     ReloadDeviceSettings();
     Mock::VerifyAndClearExpectations(this);
@@ skipping 318 matching lines @@
   SetDomainAutoComplete("");
   VerifyDomainAutoComplete(nullptr);
 
   // Check some meaningful value. Policy should be set.
   const std::string domain = "domain.test";
   const base::StringValue domain_value(domain);
   SetDomainAutoComplete(domain);
   VerifyDomainAutoComplete(&domain_value);
 }
 
+TEST_F(DeviceSettingsProviderTest, DecodeLogUploadSettings) {
+  // Turn on log upload and verify that the log upload settings have been

[Daniel Erat, 2015/08/13 15:13:39]

nit: i'd probably delete these comments; the function calls here seem
self-explanatory

+  // decoded correctly.
+  SetLogUploadSettings(true);
+  VerifyLogUploadSettings(true);
+
+  // Turn off log upload settings and verify that the settings are decoded
+  // correctly.
+  SetLogUploadSettings(false);
+  VerifyLogUploadSettings(false);
+}
 } // namespace chromeos