tools/render_pictures_main.cpp - Issue 12800002: Fixing crash in render_pictures when failing to create referenceBitmap for --validate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/render_pictures_main.cpp

Issue 12800002: Fixing crash in render_pictures when failing to create referenceBitmap for --validate (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/render_pictures_main.cpp

===================================================================

--- tools/render_pictures_main.cpp (revision 8115)

+++ tools/render_pictures_main.cpp (working copy)

@@ -163,7 +163,7 @@

success = render_picture(inputPath, NULL, referenceRenderer,

&referenceBitmap);

- if (!success || !referenceBitmap) {

+ if (!success || NULL == referenceBitmap || NULL == referenceBitmap->getPixels()) {

SkDebugf("Failed to draw the reference picture.\n");

SkDELETE(bitmap);

SkDELETE(referenceBitmap);

« no previous file with comments | « no previous file | no next file » | no next file with comments »