Add a function for parsing RFC 5280's "TBSCertificate".

net/cert/internal/parse_certificate_unittest.cc

Index: net/cert/internal/parse_certificate_unittest.cc
diff --git a/net/cert/internal/parse_certificate_unittest.cc b/net/cert/internal/parse_certificate_unittest.cc
index d83d6a58a6b29abe78d8ce965f940c3c7db70cfa..f6c047b9604e64e5f5bf19582c5b50afbc4d6dd2 100644
--- a/net/cert/internal/parse_certificate_unittest.cc
+++ b/net/cert/internal/parse_certificate_unittest.cc
@@ -19,7 +19,7 @@ std::string GetFilePath(const std::string file_name) {
 // Loads certificate data and expectations from the PEM file |file_name|.
 // Verifies that parsing the Certificate succeeds, and each parsed field matches
 // the expectations.
-void EnsureParsingCertificateSucceds(const std::string& file_name) {
+void EnsureParsingCertificateSucceeds(const std::string& file_name) {
   std::string data;
   std::string expected_tbs_certificate;
   std::string expected_signature_algorithm;
@@ -66,14 +66,14 @@ void EnsureParsingCertificateFails(const std::string& file_name) {
 
 // Tests parsing a Certificate.
 TEST(ParseCertificateTest, Version3) {
-  EnsureParsingCertificateSucceds("cert_version3.pem");
+  EnsureParsingCertificateSucceeds("cert_version3.pem");
 }
 
 // Tests parsing a simplified Certificate-like structure (the sub-fields for
 // algorithm and tbsCertificate are not actually valid, but ParseCertificate()
 // doesn't check them)
 TEST(ParseCertificateTest, Skeleton) {
-  EnsureParsingCertificateSucceds("cert_skeleton.pem");
+  EnsureParsingCertificateSucceeds("cert_skeleton.pem");
 }
 
 // Tests parsing a Certificate that is not a sequence fails.
@@ -108,6 +108,172 @@ TEST(ParseCertificateTest, AlgorithmNotSequence) {
   EnsureParsingCertificateFails("cert_algorithm_not_sequence.pem");
 }
 
+// Loads tbsCertificate data and expectations from the PEM file |file_name|.
+// Verifies that parsing the TBSCertificate succeeds, and each parsed field
+// matches the expectations.
+void EnsureParsingTbsSucceeds(const std::string& file_name,
+                              CertificateVersion expected_version) {
+  std::string data;
+  std::string expected_serial_number;
+  std::string expected_signature_algorithm;
+  std::string expected_issuer;
+  std::string expected_validity;
+  std::string expected_subject;
+  std::string expected_spki;
+  std::string expected_issuer_unique_id;
+  std::string expected_subject_unique_id;
+  std::string expected_extensions;
+
+  // Read the certificate data and test expectations from a single PEM file.
+  const PemBlockMapping mappings[] = {
+      {"TBS CERTIFICATE", &data},
+      {"SIGNATURE ALGORITHM", &expected_signature_algorithm},
+      {"SERIAL NUMBER", &expected_serial_number},
+      {"ISSUER", &expected_issuer},
+      {"VALIDITY", &expected_validity},
+      {"SUBJECT", &expected_subject},
+      {"SPKI", &expected_spki},
+      {"ISSUER UNIQUE ID", &expected_issuer_unique_id, true},
+      {"SUBJECT UNIQUE ID", &expected_subject_unique_id, true},
+      {"EXTENSIONS", &expected_extensions, true},
+  };
+  ASSERT_TRUE(ReadTestDataFromPemFile(GetFilePath(file_name), mappings));
+
+  // Parsing the TBSCertificate should succeed.
+  ParsedTbsCertificate parsed;
+  ASSERT_TRUE(ParseTbsCertificate(InputFromString(&data), &parsed));
+
+  // Ensure that the ParsedTbsCertificate matches expectations.
+  EXPECT_EQ(expected_version, parsed.version);
+
+  EXPECT_EQ(InputFromString(&expected_serial_number), parsed.serial_number);
+  EXPECT_EQ(InputFromString(&expected_signature_algorithm),
+            parsed.signature_algorithm_tlv);
+
+  EXPECT_EQ(InputFromString(&expected_issuer), parsed.issuer_tlv);
+  EXPECT_EQ(InputFromString(&expected_validity), parsed.validity_tlv);
+  EXPECT_EQ(InputFromString(&expected_subject), parsed.subject_tlv);
+  EXPECT_EQ(InputFromString(&expected_spki), parsed.spki_tlv);
+
+  EXPECT_EQ(InputFromString(&expected_issuer_unique_id),
+            parsed.issuer_unique_id.bytes());
+  EXPECT_EQ(!expected_issuer_unique_id.empty(), parsed.has_issuer_unique_id);
+  EXPECT_EQ(InputFromString(&expected_subject_unique_id),
+            parsed.subject_unique_id.bytes());
+  EXPECT_EQ(!expected_subject_unique_id.empty(), parsed.has_subject_unique_id);
+
+  EXPECT_EQ(InputFromString(&expected_extensions), parsed.extensions_tlv);
+  EXPECT_EQ(!expected_extensions.empty(), parsed.has_extensions);
+}
+
+// Loads certificate data from the PEM file |file_name| and verifies that the
+// Certificate parsing succeed, however the TBSCertificate parsing fails.
+void EnsureParsingTbsFails(const std::string& file_name) {
+  std::string data;
+
+  const PemBlockMapping mappings[] = {
+      {"TBS CERTIFICATE", &data},
+  };
+
+  ASSERT_TRUE(ReadTestDataFromPemFile(GetFilePath(file_name), mappings));
+
+  // Parsing the TBSCertificate should fail.
+  ParsedTbsCertificate parsed;
+  ASSERT_FALSE(ParseTbsCertificate(InputFromString(&data), &parsed));
+}
+
+// Tests parsing a TBSCertificate for v3 that contains no optional fields.
+TEST(ParseTbsCertificateTest, Version3NoOptionals) {
+  EnsureParsingTbsSucceeds("tbs_v3_no_optionals.pem", CertificateVersion::V3);
+}
+
+// Tests parsing a TBSCertificate for v3 that contains extensions.
+TEST(ParseTbsCertificateTest, Version3WithExtensions) {
+  EnsureParsingTbsSucceeds("tbs_v3_extensions.pem", CertificateVersion::V3);
+}
+
+// Tests parsing a TBSCertificate for v3 that contains no optional fields, and
+// has a negative serial number.
+//
+// CAs are not supposed to include negative serial numbers, however RFC 5280
+// expects consumers to deal with it anyway).
+TEST(ParseTbsCertificateTest, NegativeSerialNumber) {
+  EnsureParsingTbsSucceeds("tbs_negative_serial_number.pem",
+                           CertificateVersion::V3);
+}
+
+// Tests parsing a TBSCertificate with a serial number that is 21 octets long
+// (and the first byte is 0).
+TEST(ParseTbCertificateTest, SerialNumber21OctetsLeading0) {
+  EnsureParsingTbsFails("tbs_serial_number_21_octets_leading_0.pem");
+}
+
+// Tests parsing a TBSCertificate with a serial number that is 26 octets long
+// (and does not contain a leading 0).
+TEST(ParseTbsCertificateTest, SerialNumber26Octets) {
+  EnsureParsingTbsFails("tbs_serial_number_26_octets.pem");
+}
+
+// Tests parsing a TBSCertificate which lacks a version number (causing it to
+// default to v1).
+TEST(ParseTbsCertificateTest, Version1) {
+  EnsureParsingTbsSucceeds("tbs_v1.pem", CertificateVersion::V1);
+}
+
+// The version was set to v1 explicitly rather than omitting the version field.
+TEST(ParseTbsCertificateTest, ExplicitVersion1) {
+  EnsureParsingTbsFails("tbs_explicit_v1.pem");
+}
+
+// Extensions are not defined in version 1.
+TEST(ParseTbsCertificateTest, Version1WithExtensions) {
+  EnsureParsingTbsFails("tbs_v1_extensions.pem");
+}
+
+// Extensions are not defined in version 2.
+TEST(ParseTbsCertificateTest, Version2WithExtensions) {
+  EnsureParsingTbsFails("tbs_v2_extensions.pem");
+}
+
+// A boring version 2 certificate with none of the optional fields.
+TEST(ParseTbsCertificateTest, Version2NoOptionals) {
+  EnsureParsingTbsSucceeds("tbs_v2_no_optionals.pem", CertificateVersion::V2);
+}
+
+// A version 2 certificate with an issuer unique ID field.
+TEST(ParseTbsCertificateTest, Version2IssuerUniqueId) {
+  EnsureParsingTbsSucceeds("tbs_v2_issuer_unique_id.pem",
+                           CertificateVersion::V2);
+}
+
+// A version 2 certificate with both a issuer and subject unique ID field.
+TEST(ParseTbsCertificateTest, Version2IssuerAndSubjectUniqueId) {
+  EnsureParsingTbsSucceeds("tbs_v2_issuer_and_subject_unique_id.pem",
+                           CertificateVersion::V2);
+}
+
+// A version 3 certificate with all of the optional fields (issuer unique id,
+// subject unique id, and extensions).
+TEST(ParseTbsCertificateTest, Version3AllOptionals) {
+  EnsureParsingTbsSucceeds("tbs_v3_all_optionals.pem", CertificateVersion::V3);
+}
+
+// The version was set to v4, which is unrecognized.
+TEST(ParseTbsCertificateTest, Version4) {
+  EnsureParsingTbsFails("tbs_v4.pem");
+}
+
+// Tests that extraneous data after extensions in a v3 is rejected.
+TEST(ParseTbsCertificateTest, Version3DataAfterExtensions) {
+  EnsureParsingTbsFails("tbs_v3_data_after_extensions.pem");
+}
+
+// Tests using a real-world certificate (whereas the other tests are fabricated
+// (and in fact invalid) data.
+TEST(ParseTbsCertificateTest, Version3Real) {
+  EnsureParsingTbsSucceeds("tbs_v3_real.pem", CertificateVersion::V3);
+}
+
 }  // namespace
 
 }  // namespace net