Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 12799005: Use stream usage for dynamic vertex data. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use stream usage for dynamic vertex data. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=8129

Patch Set 1 #

Patch Set 2 : Use stream usage for dynamic vertex data. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/gpu/gl/GrGLBufferImpl.cpp View 1 3 chunks +4 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
Use stream usage for dynamic vertex data. R=robertphillips@google.com
7 years, 9 months ago (2013-03-13 13:40:40 UTC) #1
bsalomon
This will trigger the fast path for Mali and SGX in Chromium
7 years, 9 months ago (2013-03-13 13:41:07 UTC) #2
robertphillips
LGTM https://codereview.chromium.org/12799005/diff/3001/src/gpu/gl/GrGLBufferImpl.cpp File src/gpu/gl/GrGLBufferImpl.cpp (right): https://codereview.chromium.org/12799005/diff/3001/src/gpu/gl/GrGLBufferImpl.cpp#newcode18 src/gpu/gl/GrGLBufferImpl.cpp:18: GR_? Comment as to why we even have ...
7 years, 9 months ago (2013-03-13 15:20:54 UTC) #3
bsalomon
https://codereview.chromium.org/12799005/diff/3001/src/gpu/gl/GrGLBufferImpl.cpp File src/gpu/gl/GrGLBufferImpl.cpp (right): https://codereview.chromium.org/12799005/diff/3001/src/gpu/gl/GrGLBufferImpl.cpp#newcode18 src/gpu/gl/GrGLBufferImpl.cpp:18: On 2013/03/13 15:20:54, robertphillips wrote: > GR_? It's not ...
7 years, 9 months ago (2013-03-13 15:29:22 UTC) #4
bsalomon
7 years, 9 months ago (2013-03-13 15:31:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r8129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698