Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1279833003: Makes mopy turn off gtest coloring (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes mopy turn off gtest coloring Without this gtest could turn on coloring, which confuses the code that searches the output. The specific error I was getting was re was being passed a regular expression that contained escape sequences, which triggered an exception in re saying the string wasn't balanced. BUG=none TEST=none R=msw@chromium.org Committed: https://crrev.com/6ffac75a0ae783badb17b13ab7e99e9b09bcedfd Cr-Commit-Position: refs/heads/master@{#342701}

Patch Set 1 #

Patch Set 2 : move to where we copy env and remove set_color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M mojo/tools/apptest_runner.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/tools/mopy/gtest.py View 1 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sky
5 years, 4 months ago (2015-08-06 18:42:22 UTC) #1
sky
Updated as we discussed.
5 years, 4 months ago (2015-08-06 18:49:07 UTC) #2
msw
lgtm
5 years, 4 months ago (2015-08-06 18:50:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279833003/20001
5 years, 4 months ago (2015-08-06 20:04:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89942)
5 years, 4 months ago (2015-08-06 20:37:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279833003/20001
5 years, 4 months ago (2015-08-10 20:28:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 21:37:11 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 21:37:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ffac75a0ae783badb17b13ab7e99e9b09bcedfd
Cr-Commit-Position: refs/heads/master@{#342701}

Powered by Google App Engine
This is Rietveld 408576698