Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1279823004: Custom install me2me host on Linux Swarming bots. (Closed)

Created:
5 years, 4 months ago by anandc1
Modified:
5 years, 4 months ago
Reviewers:
anandc, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org, tonychun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Custom install me2me host, built as part of chromoting-integration-tests, on Linux Swarming bots. Instead of installing the me2me debian package, we'll temporarily place the required files in a custom location and run a subset of tests with it. Because the me2me host is launched from a custom location, the local-machine shows up as a remote-machine, so we'll now run connect-to-remote-host test. Most of the IT2Me tests fail because we have to update the path to the native-messaging-host in the manifest file. I tested with the manifest files thus modified but couldn't get the tests passing on the Swarming bots, so will investigate that separately (noted in tracking bug). This version should get at least some tests passing again on the Linux builder. This whole exercise is a temporary solution until we get a proper method in place to update the host. That work is tracked in http://crbug/461920 BUG=517695 Committed: https://crrev.com/ee696a52970133eebae11bf44e769c3552b5b72e Cr-Commit-Position: refs/heads/master@{#342516}

Patch Set 1 : fgfd #

Total comments: 8

Patch Set 2 : Remove unnecessary global. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M testing/chromoting/browser_test_commands_linux.txt View 1 chunk +2 lines, -11 lines 0 comments Download
M testing/chromoting/browser_tests_launcher.py View 1 4 chunks +14 lines, -4 lines 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
anandc
Hi Joe, PTAL. Thanks.
5 years, 4 months ago (2015-08-07 21:50:41 UTC) #3
joedow
https://codereview.chromium.org/1279823004/diff/20001/testing/chromoting/browser_test_commands_linux.txt File testing/chromoting/browser_test_commands_linux.txt (right): https://codereview.chromium.org/1279823004/diff/20001/testing/chromoting/browser_test_commands_linux.txt#newcode4 testing/chromoting/browser_test_commands_linux.txt:4: cd ../../remoting/internal/config && /usr/bin/python ./is_valid_json.py nit: Now that we ...
5 years, 4 months ago (2015-08-07 22:16:19 UTC) #4
anandc
Thanks Joe. PTAL. https://codereview.chromium.org/1279823004/diff/20001/testing/chromoting/browser_test_commands_linux.txt File testing/chromoting/browser_test_commands_linux.txt (right): https://codereview.chromium.org/1279823004/diff/20001/testing/chromoting/browser_test_commands_linux.txt#newcode4 testing/chromoting/browser_test_commands_linux.txt:4: cd ../../remoting/internal/config && /usr/bin/python ./is_valid_json.py On ...
5 years, 4 months ago (2015-08-07 22:26:41 UTC) #5
joedow
lgtm
5 years, 4 months ago (2015-08-07 22:33:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279823004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279823004/40001
5 years, 4 months ago (2015-08-07 22:37:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/90800)
5 years, 4 months ago (2015-08-08 00:22:04 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279823004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279823004/40001
5 years, 4 months ago (2015-08-08 00:24:20 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-08 01:19:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279823004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279823004/40001
5 years, 4 months ago (2015-08-08 04:54:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 4 months ago (2015-08-08 04:58:59 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 04:59:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee696a52970133eebae11bf44e769c3552b5b72e
Cr-Commit-Position: refs/heads/master@{#342516}

Powered by Google App Engine
This is Rietveld 408576698