Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1279763006: Fasterify ICSlotCache (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fasterify ICSlotCache Use a hash map instead of a list for faster lookups. BUG=chromium:517406 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/6ea0d55dfb9306200b86e057ac74528321ca709b Cr-Commit-Position: refs/heads/master@{#30078}

Patch Set 1 #

Patch Set 2 : lil' moar whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M src/ast.h View 1 1 chunk +16 lines, -12 lines 0 comments Download
M src/ast.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hashmap.h View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Jakob Kummerow
5 years, 4 months ago (2015-08-08 12:39:59 UTC) #1
Jakob Kummerow
The following script generates a test case that on my machine takes 3s before this ...
5 years, 4 months ago (2015-08-08 12:49:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279763006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279763006/20001
5 years, 4 months ago (2015-08-08 12:49:54 UTC) #4
Yang
On 2015/08/08 12:49:54, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 4 months ago (2015-08-08 13:09:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-08 13:26:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279763006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279763006/20001
5 years, 4 months ago (2015-08-08 16:44:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-08 16:45:27 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 16:45:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ea0d55dfb9306200b86e057ac74528321ca709b
Cr-Commit-Position: refs/heads/master@{#30078}

Powered by Google App Engine
This is Rietveld 408576698