Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1279733002: simulate drawatlas (Closed)

Created:
5 years, 4 months ago by reed2
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -9 lines) Patch
M samplecode/SampleAtlas.cpp View 7 chunks +36 lines, -9 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
reed2
ptal
5 years, 4 months ago (2015-08-06 11:58:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1279733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1279733002/1
5 years, 4 months ago (2015-08-06 11:58:28 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-06 11:58:28 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/1279733002/diff/1/samplecode/SampleAtlas.cpp File samplecode/SampleAtlas.cpp (right): https://codereview.chromium.org/1279733002/diff/1/samplecode/SampleAtlas.cpp#newcode27 samplecode/SampleAtlas.cpp:27: static void draw_atlas_sim(SkCanvas* canvas, SkImage* atlas, const SkRSXform ...
5 years, 4 months ago (2015-08-06 12:11:55 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 12:14:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fd3d87cf670e0a67ac6abefa460d4f98d756b810

Powered by Google App Engine
This is Rietveld 408576698