ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc - Issue 1279703004: Ozone: HDC should only keep track of planes owned by it’s crtc controllers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc

Issue 1279703004: Ozone: HDC should only keep track of planes owned by it’s crtc controllers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add comments to clarify what test is doing Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc

diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc

index bc670ecdaa8a99ef76c107c7fdd9fac6a361a55a..4bf1c84d631e26a953a3db3275ff44c8e9cb2214 100644

--- a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc

+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc

@@ -31,14 +31,6 @@ HardwareDisplayPlaneList::HardwareDisplayPlaneList() {

}

HardwareDisplayPlaneList::~HardwareDisplayPlaneList() {

- for (auto* plane : plane_list) {

- plane->set_in_use(false);

- plane->set_owning_crtc(0);

- }

- for (auto* plane : old_plane_list) {

- plane->set_in_use(false);

- plane->set_owning_crtc(0);

- }

}

HardwareDisplayPlaneList::PageFlipInfo::PageFlipInfo(uint32_t crtc_id,

« no previous file with comments | « ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc ('k') | no next file » | no next file with comments »