Ozone: HDC should only keep track of planes owned by it’s crtc controllers

ui/ozone/platform/drm/gpu/hardware_display_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/drm/gpu/hardware_display_controller.h"
 
 #include <drm.h>
 #include <string.h>
 #include <xf86drm.h>
 
@@ skipping 121 matching lines @@
     return true;
 
   bool status = true;
   for (size_t i = 0; i < crtc_controllers_.size(); ++i)
     status &= crtc_controllers_[i]->MoveCursor(location);
 
   return status;
 }
 
 void HardwareDisplayController::AddCrtc(scoped_ptr<CrtcController> controller) {
-  owned_hardware_planes_.add(
-      controller->drm().get(),
-      scoped_ptr<HardwareDisplayPlaneList>(new HardwareDisplayPlaneList()));
+  scoped_ptr<HardwareDisplayPlaneList> crtc_plane_list =
+      scoped_ptr<HardwareDisplayPlaneList>(new HardwareDisplayPlaneList());
+
+  // Check if this controller owns any planes and if so keep track of them.
+  scoped_refptr<DrmDevice> drm = controller->drm();
+  HardwareDisplayPlaneManager* manager = drm->plane_manager();
+  const ScopedVector<HardwareDisplayPlane>& all_planes = manager->planes();
+  uint32_t crtc = controller->crtc();
+  for (auto* plane : all_planes) {
+    if (plane->in_use() && (plane->owning_crtc() == crtc))
+      crtc_plane_list->old_plane_list.push_back(plane);
+  }
+
+  owned_hardware_planes_.add(drm.get(), crtc_plane_list.Pass());

[dnicoara, 2015/08/19 14:09:44]

Move this at the begining and use the result to get the iterator to the
crtc_plane_list.

There's a subtle behavior here as add() will not replace an already existing
element. You'll want to keep that behavior otherwise you'd be losing the planes
for the CRTCs already present.

[kalyank, 2015/08/19 15:38:54]

Done.

[kalyank, 2015/08/19 15:38:54]

Acknowledged.

   crtc_controllers_.push_back(controller.Pass());
 }
 
 scoped_ptr<CrtcController> HardwareDisplayController::RemoveCrtc(
     const scoped_refptr<DrmDevice>& drm,
     uint32_t crtc) {
   for (ScopedVector<CrtcController>::iterator it = crtc_controllers_.begin();
        it != crtc_controllers_.end(); ++it) {
     if ((*it)->drm() == drm && (*it)->crtc() == crtc) {
       scoped_ptr<CrtcController> controller(*it);
       crtc_controllers_.weak_erase(it);
       // Remove entry from |owned_hardware_planes_| iff no other crtcs share it.
       bool found = false;
       for (ScopedVector<CrtcController>::iterator it =
                crtc_controllers_.begin();
            it != crtc_controllers_.end(); ++it) {
         if ((*it)->drm() == controller->drm()) {
           found = true;
           break;
         }
       }
-      if (!found)
+      if (found) {
+        std::vector<HardwareDisplayPlane*> all_planes;
+        HardwareDisplayPlaneList* plane_list =
+            owned_hardware_planes_.get(drm.get());
+        all_planes.swap(plane_list->old_plane_list);
+        for (auto* plane : all_planes) {
+          if (plane->owning_crtc() != crtc)
+            plane_list->old_plane_list.push_back(plane);
+        }
+      } else {
         owned_hardware_planes_.erase(controller->drm().get());
+      }
 
       return controller.Pass();
     }
   }
 
   return nullptr;
 }
 
 bool HardwareDisplayController::HasCrtc(const scoped_refptr<DrmDevice>& drm,
                                         uint32_t crtc) const {
   for (size_t i = 0; i < crtc_controllers_.size(); ++i)
     if (crtc_controllers_[i]->drm() == drm &&
         crtc_controllers_[i]->crtc() == crtc)
       return true;
 
   return false;
 }
 
+bool HardwareDisplayController::HasPlane(const scoped_refptr<DrmDevice>& drm,
+                                         uint32_t plane_id,
+                                         uint32_t crtc) const {
+  HardwareDisplayPlaneList* plane_list = owned_hardware_planes_.get(drm.get());
+  if (!plane_list)
+    return false;
+
+  for (auto* plane : plane_list->old_plane_list) {
+    if (plane->plane_id() == plane_id && plane->owning_crtc() == crtc)
+      return true;
+  }
+
+  return false;
+}
+
 bool HardwareDisplayController::IsMirrored() const {
   return crtc_controllers_.size() > 1;
 }
 
 bool HardwareDisplayController::IsDisabled() const {
   return is_disabled_;
 }
 
 gfx::Size HardwareDisplayController::GetModeSize() const {
   return gfx::Size(mode_.hdisplay, mode_.vdisplay);
@@ skipping 10 matching lines @@
 
 scoped_refptr<DrmDevice> HardwareDisplayController::GetAllocationDrmDevice()
     const {
   DCHECK(!crtc_controllers_.empty());
   // TODO(dnicoara) When we support mirroring across DRM devices, figure out
   // which device should be used for allocations.
   return crtc_controllers_[0]->drm();
 }
 
 }  // namespace ui